Chromium Code Reviews

Issue 1530003003: OWNERS: Add * to .gyp{i,} everywhere. (Closed)

Created:
5 years ago by kjellander_webrtc
Modified:
5 years ago
Reviewers:
niklas.enbom
CC:
webrtc-reviews_webrtc.org, video-team_agora.io, kwiberg-webrtc, zhuangzesen_agora.io, henrika_webrtc, zhengzhonghou_agora.io, fengyue_agora.io, stefan-webrtc, tlegrand-webrtc, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, sdk-team_agora.io, peah-webrtc, minyue-webrtc, mflodman
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

OWNERS: Add * to .gyp{i,} everywhere. Also convert DOS->Unix line endings in two of the OWNERS files. NOTRY=True NOPRESUBMIT=True R=niklas.enbom@webrtc.org Committed: https://crrev.com/361888c324fe78f2427a2517d69777764d5f7564 Cr-Commit-Position: refs/heads/master@{#11056}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Rebased #

Unified diffs Side-by-side diffs Stats (+61 lines, -15 lines)
M webrtc/base/OWNERS View 1 chunk +6 lines, -0 lines 0 comments
M webrtc/modules/audio_coding/OWNERS View 1 chunk +0 lines, -2 lines 0 comments
M webrtc/modules/audio_conference_mixer/OWNERS View 1 chunk +5 lines, -0 lines 0 comments
M webrtc/modules/audio_device/OWNERS View 1 chunk +0 lines, -2 lines 0 comments
M webrtc/modules/media_file/OWNERS View 1 chunk +10 lines, -5 lines 0 comments
M webrtc/modules/rtp_rtcp/OWNERS View 1 chunk +11 lines, -6 lines 0 comments
M webrtc/modules/utility/OWNERS View 1 chunk +5 lines, -0 lines 0 comments
M webrtc/modules/video_coding/OWNERS View 1 chunk +5 lines, -0 lines 0 comments
M webrtc/modules/video_processing/OWNERS View 1 chunk +5 lines, -0 lines 0 comments
M webrtc/p2p/OWNERS View 1 chunk +5 lines, -0 lines 0 comments
M webrtc/sound/OWNERS View 1 chunk +4 lines, -0 lines 0 comments
M webrtc/system_wrappers/OWNERS View 1 chunk +5 lines, -0 lines 0 comments

Messages

Total messages: 21 (11 generated)
kjellander_webrtc
https://codereview.webrtc.org/1530003003/diff/1/webrtc/modules/audio_coding/OWNERS File webrtc/modules/audio_coding/OWNERS (left): https://codereview.webrtc.org/1530003003/diff/1/webrtc/modules/audio_coding/OWNERS#oldcode8 webrtc/modules/audio_coding/OWNERS:8: per-file *.isolate=kjellander@webrtc.org There's no longer any .isolate file in ...
5 years ago (2015-12-16 19:04:44 UTC) #3
niklas.enbom
lgtm On 2015/12/16 19:04:44, kjellander (webrtc) wrote: > https://codereview.webrtc.org/1530003003/diff/1/webrtc/modules/audio_coding/OWNERS > File webrtc/modules/audio_coding/OWNERS (left): > > ...
5 years ago (2015-12-16 19:28:25 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1530003003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1530003003/1
5 years ago (2015-12-16 19:36:45 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: presubmit on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/2466)
5 years ago (2015-12-16 19:37:50 UTC) #9
kjellander_webrtc
On 2015/12/16 19:37:50, commit-bot: I haz the power wrote: > Try jobs failed on following ...
5 years ago (2015-12-16 19:42:24 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1530003003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1530003003/1
5 years ago (2015-12-16 19:42:46 UTC) #13
commit-bot: I haz the power
Failed to apply patch for webrtc/modules/media_file/OWNERS: While running git apply --index -3 -p1; error: patch ...
5 years ago (2015-12-16 19:43:09 UTC) #15
kjellander_webrtc
Committed patchset #2 (id:20001) manually as 361888c324fe78f2427a2517d69777764d5f7564 (presubmit successful).
5 years ago (2015-12-16 19:44:44 UTC) #19
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/361888c324fe78f2427a2517d69777764d5f7564 Cr-Commit-Position: refs/heads/master@{#11056}
5 years ago (2015-12-16 19:44:44 UTC) #20
kjellander_webrtc
5 years ago (2015-12-16 19:44:53 UTC) #21
Message was sent while issue was closed. 
On 2015/12/16 19:43:09, commit-bot: I haz the power wrote:
> Failed to apply patch for webrtc/modules/media_file/OWNERS:
> While running git apply --index -3 -p1;
>   error: patch failed: webrtc/modules/media_file/OWNERS:1
>   Falling back to three-way merge...
>   error: patch failed: webrtc/modules/media_file/OWNERS:1
>   error: webrtc/modules/media_file/OWNERS: patch does not apply
> 
> Patch:       webrtc/modules/media_file/OWNERS
> Index: webrtc/modules/media_file/OWNERS
> diff --git a/webrtc/modules/media_file/OWNERS
b/webrtc/modules/media_file/OWNERS
> index
>
beb9729e0419fb8e0480533e2b92f364b0964eff..f6467a41615484d1d0c6a3148fed2549cee110fe
> 100644
> --- a/webrtc/modules/media_file/OWNERS
> +++ b/webrtc/modules/media_file/OWNERS
> @@ -1,5 +1,10 @@
> mailto:-mflodman@webrtc.org
> mailto:-perkj@webrtc.org
> mailto:-niklas.enbom@webrtc.org
> -
> -per-file mailto:BUILD.gn=kjellander@webrtc.org
> mailto:+mflodman@webrtc.org
> mailto:+perkj@webrtc.org
> mailto:+niklas.enbom@webrtc.org
> +
> +# These are for the common case of adding or renaming files. If you're doing
> +# structural changes, please get a review from a reviewer in this file.
> +per-file *.gyp=*
> +per-file *.gypi=*
> +
> +per-file mailto:BUILD.gn=kjellander@webrtc.org

*sigh*, committing manually then.

Powered by Google App Engine