Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(645)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1529673002: Fixing bug where "mid" wasn't preserved across re-offers. (Closed)

Created:
5 years ago by Taylor Brandstetter
Modified:
5 years ago
Reviewers:
pthatcher1
CC:
webrtc-reviews_webrtc.org
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Fixing bug where "mid" wasn't preserved across re-offers. Committed: https://crrev.com/44f0819978c2ba1f765835bca91e3243eb9f638b Cr-Commit-Position: refs/heads/master@{#11039}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+59 lines, -13 lines) Patch
M talk/session/media/mediasession.cc View 6 chunks +28 lines, -13 lines 0 comments Download
M talk/session/media/mediasession_unittest.cc View 3 chunks +31 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
Taylor Brandstetter
This is the bug we talked about on Friday. Pretty straightforward.
5 years ago (2015-12-14 22:48:57 UTC) #2
pthatcher1
lgtm
5 years ago (2015-12-15 07:28:23 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1529673002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1529673002/1
5 years ago (2015-12-15 19:15:03 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_rel on tryserver.webrtc (JOB_TIMED_OUT, no build URL) linux_baremetal on ...
5 years ago (2015-12-15 21:15:15 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1529673002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1529673002/1
5 years ago (2015-12-16 00:18:59 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-16 00:20:12 UTC) #10
commit-bot: I haz the power
5 years ago (2015-12-16 00:20:28 UTC) #12
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/44f0819978c2ba1f765835bca91e3243eb9f638b
Cr-Commit-Position: refs/heads/master@{#11039}

Powered by Google App Engine
This is Rietveld 408576698