Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(188)

Issue 1528863002: enabled cpplint for the webrtc/modules/rtp_rtcp directory (Closed)

Created:
5 years ago by danilchap
Modified:
5 years ago
Reviewers:
kjellander_webrtc
CC:
webrtc-reviews_webrtc.org, qiang.lu, niklas.enbom, yujie_mao (webrtc), peah-webrtc
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

enabled cpplint for the webrtc/modules/rtp_rtcp directory BUG=webrtc:5277 R=kjellander@webrtc.org NOTRY=True Committed: https://crrev.com/377b5e622f3e2f4d3b564c0d64f40ff3b5d5acb5 Cr-Commit-Position: refs/heads/master@{#11027}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M PRESUBMIT.py View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
danilchap
cpplint.py doesn't find any errors now. Some files are explicitly excluded from the check thought, ...
5 years ago (2015-12-15 12:15:05 UTC) #1
kjellander_webrtc
lgtm I added NOTRY=True to the CL description so you can land this using the ...
5 years ago (2015-12-15 12:21:34 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1528863002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1528863002/1
5 years ago (2015-12-15 12:31:14 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-15 12:33:49 UTC) #7
commit-bot: I haz the power
5 years ago (2015-12-15 12:34:00 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/377b5e622f3e2f4d3b564c0d64f40ff3b5d5acb5
Cr-Commit-Position: refs/heads/master@{#11027}

Powered by Google App Engine
This is Rietveld 408576698