Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Unified Diff: talk/app/webrtc/peerconnectioninterface.h

Issue 1528843005: Add support for GCM cipher suites from RFC 7714. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Added PeerConnection tests using GCM ciphers, fixed passing of flag through DtlsTransportChannel. Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: talk/app/webrtc/peerconnectioninterface.h
diff --git a/talk/app/webrtc/peerconnectioninterface.h b/talk/app/webrtc/peerconnectioninterface.h
index 100d8cea07b1397f115dae47f0944b1f23ba8377..3c6fe4b1373cfea321cfbb8347359ee9821d3500 100644
--- a/talk/app/webrtc/peerconnectioninterface.h
+++ b/talk/app/webrtc/peerconnectioninterface.h
@@ -548,7 +548,8 @@ class PeerConnectionFactoryInterface : public rtc::RefCountInterface {
disable_sctp_data_channels(false),
disable_network_monitor(false),
network_ignore_mask(rtc::kDefaultNetworkIgnoreMask),
- ssl_max_version(rtc::SSL_PROTOCOL_DTLS_10) {
+ ssl_max_version(rtc::SSL_PROTOCOL_DTLS_10),
+ enable_gcm_ciphers(false) {
pthatcher1 2015/12/18 20:31:31 Can you call this enable_gcm_crypto_suites to be m
joachim 2015/12/19 15:26:23 Done.
}
bool disable_encryption;
bool disable_sctp_data_channels;
@@ -563,6 +564,10 @@ class PeerConnectionFactoryInterface : public rtc::RefCountInterface {
// supported by both ends will be used for the connection, i.e. if one
// party supports DTLS 1.0 and the other DTLS 1.2, DTLS 1.0 will be used.
rtc::SSLProtocolVersion ssl_max_version;
+
+ // May GCM ciphers from RFC 7714 be used for SRTP? Only codecs supported by
+ // both endpoints will be used, GCM must be supported by both to be used.
pthatcher1 2015/12/18 20:31:31 Might be more clear as "Enable GCM crypto suites f
joachim 2015/12/19 15:26:23 Done.
+ bool enable_gcm_ciphers;
};
virtual void SetOptions(const Options& options) = 0;

Powered by Google App Engine
This is Rietveld 408576698