Lint enabled for webrtc/modules/video_coding folder.

Lint enabled for webrtc/modules/video_coding folder.

Also fixed all linting warning by using "git cl format", "//NOLINT" or
manual editing.

BUG=webrtc:5309

[philipel1, 2015-12-14 16:35:43]

Description was changed from

==========
Lint enabled for webrtc/modules/video_coding folder.

Also fixed all linting warning by using "git cl format", "//NOLINT" or
manuall editing.

clang-format

BUG=chromium:5309
==========

to

==========
Lint enabled for webrtc/modules/video_coding folder.

Also fixed all linting warning by using "git cl format", "//NOLINT" or
manual editing.

BUG=chromium:5309
==========

[philipel1, 2015-12-14 16:40:14]

Description was changed from

==========
Lint enabled for webrtc/modules/video_coding folder.

Also fixed all linting warning by using "git cl format", "//NOLINT" or
manual editing.

BUG=chromium:5309
==========

to

==========
Lint enabled for webrtc/modules/video_coding folder.

Also fixed all linting warning by using "git cl format", "//NOLINT" or
manual editing.

BUG=webrtc:5309
==========

[mflodman, 2015-12-17 13:05:38]

mflodman@webrtc.org changed reviewers:
+ mflodman@webrtc.org

[mflodman, 2015-12-17 13:05:39]

Really hard to review the diff in some cases, assuming only format changes on
these files.

Mainly comments around include order.

https://codereview.webrtc.org/1528503003/diff/1/PRESUBMIT.py
File PRESUBMIT.py (left):

https://codereview.webrtc.org/1528503003/diff/1/PRESUBMIT.py#oldcode1
PRESUBMIT.py:1: # Copyright (c) 2012 The WebRTC project authors. All Rights
Reserved.
Don't remove this.

https://codereview.webrtc.org/1528503003/diff/1/PRESUBMIT.py
File PRESUBMIT.py (right):

https://codereview.webrtc.org/1528503003/diff/1/PRESUBMIT.py#newcode23
PRESUBMIT.py:23: 'webrtc/modules/video_coding',
Alphabetic order.

https://codereview.webrtc.org/1528503003/diff/1/webrtc/base/timing.cc
File webrtc/base/timing.cc (right):

https://codereview.webrtc.org/1528503003/diff/1/webrtc/base/timing.cc#newcode11
webrtc/base/timing.cc:11: #include <algorithm>
What is this used for here?

https://codereview.webrtc.org/1528503003/diff/1/webrtc/modules/video_coding/c...
File webrtc/modules/video_coding/codecs/vp8/screenshare_layers.cc (right):

https://codereview.webrtc.org/1528503003/diff/1/webrtc/modules/video_coding/c...
webrtc/modules/video_coding/codecs/vp8/screenshare_layers.cc:17: #include
"webrtc/modules/video_coding/codecs/vp8/screenshare_layers.h"
This should be kept on top.

https://codereview.webrtc.org/1528503003/diff/1/webrtc/modules/video_coding/c...
File webrtc/modules/video_coding/codecs/vp8/vp8_sequence_coder.cc (right):

https://codereview.webrtc.org/1528503003/diff/1/webrtc/modules/video_coding/c...
webrtc/modules/video_coding/codecs/vp8/vp8_sequence_coder.cc:1: /*
Move back line 2 - 9 one step to the right.

https://codereview.webrtc.org/1528503003/diff/1/webrtc/modules/video_coding/g...
File webrtc/modules/video_coding/generic_encoder.cc (right):

https://codereview.webrtc.org/1528503003/diff/1/webrtc/modules/video_coding/g...
webrtc/modules/video_coding/generic_encoder.cc:18: #include
"webrtc/modules/video_coding/generic_encoder.h"
Should be on top.

https://codereview.webrtc.org/1528503003/diff/1/webrtc/modules/video_coding/j...
File webrtc/modules/video_coding/jitter_estimator.cc (right):

https://codereview.webrtc.org/1528503003/diff/1/webrtc/modules/video_coding/j...
webrtc/modules/video_coding/jitter_estimator.cc:18: #include
"webrtc/modules/video_coding/jitter_estimator.h"
Should be on top.

https://codereview.webrtc.org/1528503003/diff/1/webrtc/modules/video_coding/p...
File webrtc/modules/video_coding/packet.cc (right):

https://codereview.webrtc.org/1528503003/diff/1/webrtc/modules/video_coding/p...
webrtc/modules/video_coding/packet.cc:14: #include
"webrtc/modules/video_coding/packet.h"
On top.

https://codereview.webrtc.org/1528503003/diff/1/webrtc/modules/video_coding/r...
File webrtc/modules/video_coding/rtt_filter.cc (right):

https://codereview.webrtc.org/1528503003/diff/1/webrtc/modules/video_coding/r...
webrtc/modules/video_coding/rtt_filter.cc:16: #include
"webrtc/modules/video_coding/rtt_filter.h"
On top.

https://codereview.webrtc.org/1528503003/diff/1/webrtc/modules/video_coding/t...
File webrtc/modules/video_coding/timing.cc (right):

https://codereview.webrtc.org/1528503003/diff/1/webrtc/modules/video_coding/t...
webrtc/modules/video_coding/timing.cc:13: #include
"webrtc/modules/video_coding/timing.h"
Should be on top.

https://codereview.webrtc.org/1528503003/diff/1/webrtc/modules/video_coding/t...
File webrtc/modules/video_coding/timing.h (right):

https://codereview.webrtc.org/1528503003/diff/1/webrtc/modules/video_coding/t...
webrtc/modules/video_coding/timing.h:28: explicit VCMTiming(Clock* clock,
VCMTiming* master_timing = NULL);
Should not be explicit.

https://codereview.webrtc.org/1528503003/diff/1/webrtc/modules/video_coding/v...
File webrtc/modules/video_coding/video_coding_impl.cc (right):

https://codereview.webrtc.org/1528503003/diff/1/webrtc/modules/video_coding/v...
webrtc/modules/video_coding/video_coding_impl.cc:19: #include
"webrtc/modules/video_coding/video_coding_impl.h"
Should be on top.

[philipel, 2015-12-18 12:23:16]

https://codereview.webrtc.org/1528503003/diff/1/PRESUBMIT.py
File PRESUBMIT.py (right):

https://codereview.webrtc.org/1528503003/diff/1/PRESUBMIT.py#newcode23
PRESUBMIT.py:23: 'webrtc/modules/video_coding',
On 2015/12/17 13:05:39, mflodman wrote:
> Alphabetic order.

Done.

https://codereview.webrtc.org/1528503003/diff/1/webrtc/base/timing.cc
File webrtc/base/timing.cc (right):

https://codereview.webrtc.org/1528503003/diff/1/webrtc/base/timing.cc#newcode11
webrtc/base/timing.cc:11: #include <algorithm>
On 2015/12/17 13:05:39, mflodman wrote:
> What is this used for here? 

Removed

https://codereview.webrtc.org/1528503003/diff/1/webrtc/modules/video_coding/c...
File webrtc/modules/video_coding/codecs/vp8/screenshare_layers.cc (right):

https://codereview.webrtc.org/1528503003/diff/1/webrtc/modules/video_coding/c...
webrtc/modules/video_coding/codecs/vp8/screenshare_layers.cc:17: #include
"webrtc/modules/video_coding/codecs/vp8/screenshare_layers.h"
On 2015/12/17 13:05:39, mflodman wrote:
> This should be kept on top.

Done.

https://codereview.webrtc.org/1528503003/diff/1/webrtc/modules/video_coding/c...
File webrtc/modules/video_coding/codecs/vp8/vp8_sequence_coder.cc (right):

https://codereview.webrtc.org/1528503003/diff/1/webrtc/modules/video_coding/c...
webrtc/modules/video_coding/codecs/vp8/vp8_sequence_coder.cc:1: /*
On 2015/12/17 13:05:39, mflodman wrote:
> Move back line 2 - 9 one step to the right.

Done.

https://codereview.webrtc.org/1528503003/diff/1/webrtc/modules/video_coding/g...
File webrtc/modules/video_coding/generic_encoder.cc (right):

https://codereview.webrtc.org/1528503003/diff/1/webrtc/modules/video_coding/g...
webrtc/modules/video_coding/generic_encoder.cc:18: #include
"webrtc/modules/video_coding/generic_encoder.h"
On 2015/12/17 13:05:39, mflodman wrote:
> Should be on top.

Done.

https://codereview.webrtc.org/1528503003/diff/1/webrtc/modules/video_coding/j...
File webrtc/modules/video_coding/jitter_estimator.cc (right):

https://codereview.webrtc.org/1528503003/diff/1/webrtc/modules/video_coding/j...
webrtc/modules/video_coding/jitter_estimator.cc:18: #include
"webrtc/modules/video_coding/jitter_estimator.h"
On 2015/12/17 13:05:39, mflodman wrote:
> Should be on top.

Done.

https://codereview.webrtc.org/1528503003/diff/1/webrtc/modules/video_coding/p...
File webrtc/modules/video_coding/packet.cc (right):

https://codereview.webrtc.org/1528503003/diff/1/webrtc/modules/video_coding/p...
webrtc/modules/video_coding/packet.cc:14: #include
"webrtc/modules/video_coding/packet.h"
On 2015/12/17 13:05:39, mflodman wrote:
> On top.

Done.

https://codereview.webrtc.org/1528503003/diff/1/webrtc/modules/video_coding/r...
File webrtc/modules/video_coding/rtt_filter.cc (right):

https://codereview.webrtc.org/1528503003/diff/1/webrtc/modules/video_coding/r...
webrtc/modules/video_coding/rtt_filter.cc:16: #include
"webrtc/modules/video_coding/rtt_filter.h"
On 2015/12/17 13:05:39, mflodman wrote:
> On top.

Done.

https://codereview.webrtc.org/1528503003/diff/1/webrtc/modules/video_coding/t...
File webrtc/modules/video_coding/timing.cc (right):

https://codereview.webrtc.org/1528503003/diff/1/webrtc/modules/video_coding/t...
webrtc/modules/video_coding/timing.cc:13: #include
"webrtc/modules/video_coding/timing.h"
On 2015/12/17 13:05:39, mflodman wrote:
> Should be on top.

Done.

https://codereview.webrtc.org/1528503003/diff/1/webrtc/modules/video_coding/t...
File webrtc/modules/video_coding/timing.h (right):

https://codereview.webrtc.org/1528503003/diff/1/webrtc/modules/video_coding/t...
webrtc/modules/video_coding/timing.h:28: explicit VCMTiming(Clock* clock,
VCMTiming* master_timing = NULL);
On 2015/12/17 13:05:39, mflodman wrote:
> Should not be explicit.

Done.

[mflodman, 2015-12-18 12:44:27]

Two things missed from first set of comments.

https://codereview.webrtc.org/1528503003/diff/1/webrtc/modules/video_coding/v...
File webrtc/modules/video_coding/video_coding_impl.cc (right):

https://codereview.webrtc.org/1528503003/diff/1/webrtc/modules/video_coding/v...
webrtc/modules/video_coding/video_coding_impl.cc:19: #include
"webrtc/modules/video_coding/video_coding_impl.h"
On 2015/12/17 13:05:39, mflodman wrote:
> Should be on top.

You missed this comment.

https://codereview.webrtc.org/1528503003/diff/20001/webrtc/modules/video_codi...
File webrtc/modules/video_coding/codecs/vp8/vp8_sequence_coder.cc (right):

https://codereview.webrtc.org/1528503003/diff/20001/webrtc/modules/video_codi...
webrtc/modules/video_coding/codecs/vp8/vp8_sequence_coder.cc:1: /*
Line one should have been kept  one step to the left.

[mflodman, 2015-12-18 13:03:53]

LGTM

[philipel, 2015-12-18 13:27:20]

The CQ bit was checked by philipel@webrtc.org

[commit-bot: I haz the power, 2015-12-18 13:27:31]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1528503003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1528503003/40001

[commit-bot: I haz the power, 2015-12-18 13:28:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-12-18 13:28:43]

Try jobs failed on following builders:
  android_gn_dbg on tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/android_gn_dbg/builds/7728)
  linux_asan on tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/linux_asan/builds/11468)
  linux_tsan2 on tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/linux_tsan2/builds/8833)

[philipel, 2015-12-18 13:44:37]

Rebase

[philipel, 2015-12-18 13:44:54]

The CQ bit was checked by philipel@webrtc.org

[philipel, 2015-12-18 13:44:55]

The patchset sent to the CQ was uploaded after l-g-t-m from mflodman@webrtc.org
Link to the patchset: https://codereview.webrtc.org/1528503003/#ps60001 (title:
"Rebase")

[commit-bot: I haz the power, 2015-12-18 13:45:06]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1528503003/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1528503003/60001

[commit-bot: I haz the power, 2015-12-18 13:47:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-12-18 13:47:50]

Try jobs failed on following builders:
  ios_arm64_rel on tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/ios_arm64_rel/builds/6363)
  mac_compile_x64_dbg on tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/mac_compile_x64_dbg/bui...)

[philipel, 2015-12-18 14:26:11]

unsigned int/uint64_t fix

[philipel, 2015-12-18 14:26:36]

The CQ bit was checked by philipel@webrtc.org

[philipel, 2015-12-18 14:26:36]

The patchset sent to the CQ was uploaded after l-g-t-m from mflodman@webrtc.org
Link to the patchset: https://codereview.webrtc.org/1528503003/#ps80001 (title:
"unsigned int/uint64_t fix")

[commit-bot: I haz the power, 2015-12-18 14:26:41]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1528503003/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1528503003/80001

[commit-bot: I haz the power, 2015-12-18 14:30:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-12-18 14:30:10]

Try jobs failed on following builders:
  ios_arm64_rel on tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/ios_arm64_rel/builds/6370)
  ios_rel on tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/ios_rel/builds/10264)
  mac_compile_x64_dbg on tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/mac_compile_x64_dbg/bui...)
  mac_rel on tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/mac_rel/builds/11700)

[philipel, 2015-12-18 14:38:05]

unsigned int/uint64_t fix

[philipel, 2015-12-18 14:38:20]

The CQ bit was checked by philipel@webrtc.org

[philipel, 2015-12-18 14:38:20]

The patchset sent to the CQ was uploaded after l-g-t-m from mflodman@webrtc.org
Link to the patchset: https://codereview.webrtc.org/1528503003/#ps100001 (title:
"unsigned int/uint64_t fix")

[commit-bot: I haz the power, 2015-12-18 14:38:37]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1528503003/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1528503003/100001

[commit-bot: I haz the power, 2015-12-18 14:54:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-12-18 14:54:57]

Try jobs failed on following builders:
  presubmit on tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/2515)

[philipel, 2015-12-18 16:10:07]

The CQ bit was checked by philipel@webrtc.org

[philipel, 2015-12-18 16:10:08]

The patchset sent to the CQ was uploaded after l-g-t-m from mflodman@webrtc.org
Link to the patchset: https://codereview.webrtc.org/1528503003/#ps140001 (title:
"Rebase")

[commit-bot: I haz the power, 2015-12-18 16:10:12]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1528503003/140001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1528503003/140001

[commit-bot: I haz the power, 2015-12-18 16:15:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-12-18 16:15:02]

Try jobs failed on following builders:
  win_rel on tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/win_rel/builds/11725)
  win_x64_gn_dbg on tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/win_x64_gn_dbg/builds/6061)