Add implementation in metrics.h that uses atomic pointer.

Add implementation in metrics.h that uses atomic pointer.

Update test implementation (test/histograms.h) to be more similar a real implementation (where histogram get functions return a Histogram pointer). Add check that the name of a histogram does not change.

BUG=webrtc:5283
Committed: https://crrev.com/1fe48a5e1dbc752b24b6c63eb2e6abd80c01c1dc
Cr-Commit-Position: refs/heads/master@{#11161}

[åsapersson, 2015-12-16 17:12:46]

Description was changed from

==========
sfsf


sfsf

BUG=
==========

to

==========
Add implementation in metrics.h that uses atomic pointer.

BUG=webrtc:5283
==========

[åsapersson, 2015-12-17 12:55:51]

Patchset #7 (id:120001) has been deleted

[åsapersson, 2015-12-17 12:55:57]

Patchset #7 (id:140001) has been deleted

[åsapersson, 2015-12-17 12:56:04]

Patchset #6 (id:100001) has been deleted

[åsapersson, 2015-12-17 12:56:15]

Patchset #5 (id:80001) has been deleted

[åsapersson, 2015-12-18 13:54:12]

Patchset #7 (id:190001) has been deleted

[åsapersson, 2015-12-18 13:54:27]

Patchset #8 (id:230001) has been deleted

[åsapersson, 2015-12-18 13:54:40]

Patchset #10 (id:290001) has been deleted

[åsapersson, 2015-12-18 13:54:48]

Patchset #9 (id:270001) has been deleted

[åsapersson, 2015-12-18 16:12:59]

Patchset #7 (id:210001) has been deleted

[åsapersson, 2015-12-18 16:13:16]

Patchset #8 (id:310001) has been deleted

[åsapersson, 2015-12-18 16:13:24]

Patchset #9 (id:340001) has been deleted

[åsapersson, 2015-12-18 16:13:39]

Patchset #9 (id:360001) has been deleted

[åsapersson, 2015-12-18 16:13:50]

Patchset #3 (id:40001) has been deleted

[åsapersson, 2015-12-18 16:14:08]

Patchset #2 (id:20001) has been deleted

[åsapersson, 2015-12-18 16:14:20]

Patchset #2 (id:60001) has been deleted

[åsapersson, 2015-12-18 16:14:47]

Patchset #5 (id:200017) has been deleted

[åsapersson, 2015-12-21 13:20:40]

Description was changed from

==========
Add implementation in metrics.h that uses atomic pointer.

BUG=webrtc:5283
==========

to

==========
Add implementation in metrics.h that uses atomic pointer.

Update test implementation (test/histograms.h) to be more similar a real
implementation (where histogram get functions return a Histogram pointer). Add
check that the name of a histogram does not change.

BUG=webrtc:5283
==========

[åsapersson, 2015-12-21 13:20:40]

asapersson@webrtc.org changed reviewers:
+ mflodman@webrtc.org, pbos@webrtc.org

[åsapersson, 2015-12-21 13:29:31]

Patchset #8 (id:430001) has been deleted

[åsapersson, 2015-12-21 13:29:46]

Patchset #6 (id:390001) has been deleted

[pbos-webrtc, 2015-12-21 13:44:43]

lgtm

https://codereview.webrtc.org/1528403003/diff/450001/webrtc/system_wrappers/i...
File webrtc/system_wrappers/include/metrics.h (right):

https://codereview.webrtc.org/1528403003/diff/450001/webrtc/system_wrappers/i...
webrtc/system_wrappers/include/metrics.h:126: // TODO(asapersson): Consider
changing string to const char*.
FTR: I think you should def. do this, const char* makes it harder to use
wrongly.

https://codereview.webrtc.org/1528403003/diff/450001/webrtc/system_wrappers/i...
webrtc/system_wrappers/include/metrics.h:138: histogram_pointer); \
Consider DCHECKing that this previous value was either nullptr or the value
you're setting it to (histogram_pointer).

https://codereview.webrtc.org/1528403003/diff/450001/webrtc/system_wrappers/i...
webrtc/system_wrappers/include/metrics.h:145: #define
RTC_HISTOGRAM_COMMON_BLOCK_SLOW(name, sample, factory_get_invocation) \
Should we consider getting rid of this implementation as well?

https://codereview.webrtc.org/1528403003/diff/450001/webrtc/test/histogram.cc
File webrtc/test/histogram.cc (right):

https://codereview.webrtc.org/1528403003/diff/450001/webrtc/test/histogram.cc...
webrtc/test/histogram.cc:26: SampleInfo(const std::string& name)
consider const char* here as well

[åsapersson, 2015-12-21 16:45:33]

https://codereview.webrtc.org/1528403003/diff/450001/webrtc/system_wrappers/i...
File webrtc/system_wrappers/include/metrics.h (right):

https://codereview.webrtc.org/1528403003/diff/450001/webrtc/system_wrappers/i...
webrtc/system_wrappers/include/metrics.h:126: // TODO(asapersson): Consider
changing string to const char*.
On 2015/12/21 13:44:42, pbos-webrtc wrote:
> FTR: I think you should def. do this, const char* makes it harder to use
> wrongly.

Ok, will look at that in a separate CL.

https://codereview.webrtc.org/1528403003/diff/450001/webrtc/system_wrappers/i...
webrtc/system_wrappers/include/metrics.h:138: histogram_pointer); \
On 2015/12/21 13:44:43, pbos-webrtc wrote:
> Consider DCHECKing that this previous value was either nullptr or the value
> you're setting it to (histogram_pointer).

Done.

https://codereview.webrtc.org/1528403003/diff/450001/webrtc/system_wrappers/i...
webrtc/system_wrappers/include/metrics.h:145: #define
RTC_HISTOGRAM_COMMON_BLOCK_SLOW(name, sample, factory_get_invocation) \
On 2015/12/21 13:44:42, pbos-webrtc wrote:
> Should we consider getting rid of this implementation as well?

Yes when all sparse are removed. Added deprecated comment.

https://codereview.webrtc.org/1528403003/diff/450001/webrtc/test/histogram.cc
File webrtc/test/histogram.cc (right):

https://codereview.webrtc.org/1528403003/diff/450001/webrtc/test/histogram.cc...
webrtc/test/histogram.cc:26: SampleInfo(const std::string& name)
On 2015/12/21 13:44:43, pbos-webrtc wrote:
> consider const char* here as well

Acknowledged.

[mflodman, 2015-12-22 09:20:04]

LGTM

[åsapersson, 2016-01-07 07:56:43]

The CQ bit was checked by asapersson@webrtc.org

[åsapersson, 2016-01-07 07:56:43]

The patchset sent to the CQ was uploaded after l-g-t-m from pbos@webrtc.org
Link to the patchset: https://codereview.webrtc.org/1528403003/#ps470001 (title:
"address comments")

[commit-bot: I haz the power, 2016-01-07 07:56:52]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1528403003/470001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1528403003/470001

[commit-bot: I haz the power, 2016-01-07 09:02:45]

Description was changed from

==========
Add implementation in metrics.h that uses atomic pointer.

Update test implementation (test/histograms.h) to be more similar a real
implementation (where histogram get functions return a Histogram pointer). Add
check that the name of a histogram does not change.

BUG=webrtc:5283
==========

to

==========
Add implementation in metrics.h that uses atomic pointer.

Update test implementation (test/histograms.h) to be more similar a real
implementation (where histogram get functions return a Histogram pointer). Add
check that the name of a histogram does not change.

BUG=webrtc:5283
==========

[commit-bot: I haz the power, 2016-01-07 09:02:46]

Committed patchset #8 (id:470001)

[commit-bot: I haz the power, 2016-01-07 09:02:58]

Description was changed from

==========
Add implementation in metrics.h that uses atomic pointer.

Update test implementation (test/histograms.h) to be more similar a real
implementation (where histogram get functions return a Histogram pointer). Add
check that the name of a histogram does not change.

BUG=webrtc:5283
==========

to

==========
Add implementation in metrics.h that uses atomic pointer.

Update test implementation (test/histograms.h) to be more similar a real
implementation (where histogram get functions return a Histogram pointer). Add
check that the name of a histogram does not change.

BUG=webrtc:5283

Committed: https://crrev.com/1fe48a5e1dbc752b24b6c63eb2e6abd80c01c1dc
Cr-Commit-Position: refs/heads/master@{#11161}
==========

[commit-bot: I haz the power, 2016-01-07 09:02:59]

Patchset 8 (id:??) landed as
https://crrev.com/1fe48a5e1dbc752b24b6c63eb2e6abd80c01c1dc
Cr-Commit-Position: refs/heads/master@{#11161}