Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(315)

Issue 1527933002: Add speech encoder to the encoder stack specification struct (Closed)

Created:
5 years ago by kwiberg-webrtc
Modified:
5 years ago
Reviewers:
hlundin-webrtc
CC:
webrtc-reviews_webrtc.org, kwiberg-webrtc, tlegrand-webrtc, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, peah-webrtc, minyue-webrtc, the sun
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Add speech encoder to the encoder stack specification struct BUG=webrtc:5028 Committed: https://crrev.com/95d9851a6ca25208e4566dedeb149a6680c512a8 Cr-Commit-Position: refs/heads/master@{#11037}

Patch Set 1 #

Patch Set 2 : death test #

Patch Set 3 : don't death test on android #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -31 lines) Patch
M webrtc/modules/audio_coding/acm2/codec_manager.cc View 5 chunks +11 lines, -8 lines 0 comments Download
M webrtc/modules/audio_coding/acm2/rent_a_codec.h View 2 chunks +4 lines, -5 lines 0 comments Download
M webrtc/modules/audio_coding/acm2/rent_a_codec.cc View 1 chunk +9 lines, -10 lines 0 comments Download
M webrtc/modules/audio_coding/acm2/rent_a_codec_unittest.cc View 1 2 5 chunks +21 lines, -8 lines 0 comments Download

Messages

Total messages: 15 (8 generated)
kwiberg-webrtc
5 years ago (2015-12-15 11:06:07 UTC) #3
hlundin-webrtc
lgtm
5 years ago (2015-12-15 11:18:28 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1527933002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1527933002/40001
5 years ago (2015-12-15 13:08:08 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_rel on tryserver.webrtc (JOB_TIMED_OUT, no build URL) win_baremetal on ...
5 years ago (2015-12-15 15:08:24 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1527933002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1527933002/40001
5 years ago (2015-12-15 22:19:28 UTC) #11
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years ago (2015-12-15 22:21:40 UTC) #13
commit-bot: I haz the power
5 years ago (2015-12-15 22:21:50 UTC) #15
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/95d9851a6ca25208e4566dedeb149a6680c512a8
Cr-Commit-Position: refs/heads/master@{#11037}

Powered by Google App Engine
This is Rietveld 408576698