Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1478)

Unified Diff: talk/app/webrtc/peerconnection_unittest.cc

Issue 1527833003: Fixing flaky LocalP2PTestSctpDataChannel test. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: talk/app/webrtc/peerconnection_unittest.cc
diff --git a/talk/app/webrtc/peerconnection_unittest.cc b/talk/app/webrtc/peerconnection_unittest.cc
index 605e1a5e1f91f83701f17a8cd3e6a63c9a5bd1a7..8071ac9bb6bf978e768ab6fcd1f5528eb0ab3bf3 100644
--- a/talk/app/webrtc/peerconnection_unittest.cc
+++ b/talk/app/webrtc/peerconnection_unittest.cc
@@ -1585,10 +1585,9 @@ TEST_F(P2PTestConductor, LocalP2PTestSctpDataChannel) {
kMaxWaitMs);
receiving_client()->data_channel()->Close();
- // Send new offer and answer.
- receiving_client()->Negotiate();
- EXPECT_FALSE(initializing_client()->data_observer()->IsOpen());
- EXPECT_FALSE(receiving_client()->data_observer()->IsOpen());
+ EXPECT_TRUE_WAIT(!initializing_client()->data_observer()->IsOpen(),
+ kMaxWaitMs);
+ EXPECT_TRUE_WAIT(!receiving_client()->data_observer()->IsOpen(), kMaxWaitMs);
}
// This test sets up a call between two parties and creates a data channel.
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698