Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issue 1527833003: Fixing flaky LocalP2PTestSctpDataChannel test. (Closed)

Created:
5 years ago by Taylor Brandstetter
Modified:
5 years ago
Reviewers:
CC:
webrtc-reviews_webrtc.org
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Fixing flaky LocalP2PTestSctpDataChannel test. SCTP data channels are closed asynchronously in-band, unlike RTP data channels, so the test must be slightly modified. TBR=pthatcher@webrtc.org Committed: https://crrev.com/158879305bf5910c0b9e3630a073324a048b59ef Cr-Commit-Position: refs/heads/master@{#11017}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -4 lines) Patch
M talk/app/webrtc/peerconnection_unittest.cc View 1 chunk +3 lines, -4 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1527833003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1527833003/1
5 years ago (2015-12-15 00:31:21 UTC) #3
commit-bot: I haz the power
Try jobs failed on following builders: linux_baremetal on tryserver.webrtc (JOB_TIMED_OUT, no build URL) mac_baremetal on ...
5 years ago (2015-12-15 02:32:31 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1527833003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1527833003/1
5 years ago (2015-12-15 03:06:42 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-15 03:32:38 UTC) #9
commit-bot: I haz the power
5 years ago (2015-12-15 03:32:43 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/158879305bf5910c0b9e3630a073324a048b59ef
Cr-Commit-Position: refs/heads/master@{#11017}

Powered by Google App Engine
This is Rietveld 408576698