Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Issue 1527143007: AudioDeviceTest.StartPlayoutOnTwoInstances now verifies two active playing streams (Closed)

Created:
5 years ago by henrika_webrtc
Modified:
4 years, 11 months ago
Reviewers:
tkchin_webrtc
CC:
webrtc-reviews_webrtc.org
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

AudioDeviceTest.StartPlayoutOnTwoInstances now verifies two active playing streams TBR=tkchin_webrtc BUG=b/25343768 Committed: https://crrev.com/46ea3ce5802f76bdd9177ec495cbc581bf021313 Cr-Commit-Position: refs/heads/master@{#11165}

Patch Set 1 #

Patch Set 2 : nit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -9 lines) Patch
M webrtc/modules/audio_device/ios/audio_device_unittest_ios.cc View 1 5 chunks +20 lines, -9 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
henrika_webrtc
Extended the test so it now actually starts two streams (one per ADM using two ...
5 years ago (2015-12-18 15:13:16 UTC) #3
henrika_webrtc
Landing this one with TBR=tkchin_webrtc since it is a simple change and I would like ...
4 years, 11 months ago (2016-01-07 14:01:13 UTC) #5
henrika_webrtc
The mac_baremetal issue is not related to this CL since it only affects iOS.
4 years, 11 months ago (2016-01-07 14:02:11 UTC) #6
henrika_webrtc
Committed patchset #2 (id:20001) manually as 46ea3ce5802f76bdd9177ec495cbc581bf021313 (presubmit successful).
4 years, 11 months ago (2016-01-07 14:03:13 UTC) #8
commit-bot: I haz the power
4 years, 11 months ago (2016-01-07 14:03:15 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/46ea3ce5802f76bdd9177ec495cbc581bf021313
Cr-Commit-Position: refs/heads/master@{#11165}

Powered by Google App Engine
This is Rietveld 408576698