Update API for Objective-C RTCMediaStreamTrack

webrtc/api/objc/RTCMediaStreamTrack.mm

Index: webrtc/api/objc/RTCMediaStreamTrack.mm
diff --git a/webrtc/api/objc/RTCMediaStreamTrack.mm b/webrtc/api/objc/RTCMediaStreamTrack.mm
new file mode 100644
index 0000000000000000000000000000000000000000..6b5d7b314cf8268fbc2ce371dcfc0c067a02a81b
--- /dev/null
+++ b/webrtc/api/objc/RTCMediaStreamTrack.mm
@@ -0,0 +1,109 @@
+/*
+ *  Copyright 2015 The WebRTC project authors. All Rights Reserved.
+ *
+ *  Use of this source code is governed by a BSD-style license
+ *  that can be found in the LICENSE file in the root of the source
+ *  tree. An additional intellectual property rights grant can be found
+ *  in the file PATENTS.  All contributing project authors may
+ *  be found in the AUTHORS file in the root of the source tree.
+ */
+
+#import "RTCMediaStreamTrack.h"
+
+#import "webrtc/api/objc/RTCMediaStreamTrack+Private.h"
+#import "webrtc/base/objc/NSString+StdString.h"
+
+@interface RTCMediaStreamTrack () {
+  rtc::scoped_refptr<webrtc::MediaStreamTrackInterface> _track;
+}
+@end
+
+@implementation RTCMediaStreamTrack
+
+- (NSString *)kind {
+  return [NSString stringForStdString:_track->kind()];
+}
+
+- (NSString *)id {
+  return [NSString stringForStdString:_track->id()];
+}
+
+- (BOOL)isEnabled {
+  return _track->enabled();
+}
+
+- (void)setEnabled:(BOOL)enabled {
+  _track->set_enabled(enabled);
+}
+
+- (RTCMediaStreamTrackState)readyState {
+  return [[self class] objCTrackStateForNativeTrackState:_track->state()];
+}
+
+- (NSString *)description {
+  return [NSString stringWithFormat:@"RTCMediaStreamTrack:\n%@\n%@\n%@\n%@",
+                                    self.kind,
+                                    self.id,
+                                    self.enabled ? @"enabled" : @"disabled",
+                                    [[self class] descriptionForObjCTrackState:
+                                        self.readyState]];
+}
+
+#pragma mark - Private
+
+- (rtc::scoped_refptr<webrtc::MediaStreamTrackInterface>)nativeTrack {
+  return _track;
+}
+
+- (instancetype)initWithTrack:

[tkchin_webrtc, 2016/01/05 16:43:34]

maybe initWithNativeTrack

[hjon, 2016/01/05 22:48:19]

Done.

+    (rtc::scoped_refptr<webrtc::MediaStreamTrackInterface>)track {
+  NSParameterAssert(track);
+  if (self = [super init]) {
+    _track =  track;
+  }
+  return self;
+}
+
++ (webrtc::MediaStreamTrackInterface::TrackState)nativeTrackStateForObjCTrackState:

[tkchin_webrtc, 2016/01/05 16:43:34]

what I've been doing is appending "native"
e.g.
nativeTrackStateForState:
trackStateForNativeState:

Basically the odd thing out is the C++ stuff, so prefix that only.

[hjon, 2016/01/05 22:48:19]

Done.

+    (RTCMediaStreamTrackState)state {
+  switch (state) {
+    case RTCMediaStreamTrackStateInitializing:
+      return webrtc::MediaStreamTrackInterface::kInitializing;
+    case RTCMediaStreamTrackStateLive:
+      return webrtc::MediaStreamTrackInterface::kLive;
+    case RTCMediaStreamTrackStateEnded:
+      return webrtc::MediaStreamTrackInterface::kEnded;
+    case RTCMediaStreamTrackStateFailed:
+      return webrtc::MediaStreamTrackInterface::kFailed;
+  }
+}
+
++ (RTCMediaStreamTrackState)objCTrackStateForNativeTrackState:
+    (webrtc::MediaStreamTrackInterface::TrackState)nativeState {
+  switch (nativeState) {
+    case webrtc::MediaStreamTrackInterface::kInitializing:
+      return RTCMediaStreamTrackStateInitializing;
+    case webrtc::MediaStreamTrackInterface::kLive:
+      return RTCMediaStreamTrackStateLive;
+    case webrtc::MediaStreamTrackInterface::kEnded:
+      return RTCMediaStreamTrackStateEnded;
+    case webrtc::MediaStreamTrackInterface::kFailed:
+      return RTCMediaStreamTrackStateFailed;
+  }
+}
+
++ (NSString *)descriptionForObjCTrackState:

[tkchin_webrtc, 2016/01/05 16:43:34]

stringForState: or descriptionForState: (but keep it consistent in other files
too)
there might be cases where you will want stateForString: or stateForDescription:
in which case I'd lean towards stringForState/stateForString

[hjon, 2016/01/05 22:48:19]

Done.

+    (RTCMediaStreamTrackState)state {
+  switch (state) {
+    case RTCMediaStreamTrackStateInitializing:
+      return @"Initializing";
+    case RTCMediaStreamTrackStateLive:
+      return @"Live";
+    case RTCMediaStreamTrackStateEnded:
+      return @"Ended";
+    case RTCMediaStreamTrackStateFailed:
+      return @"Failed";
+  }
+}
+
+@end