Update API for Objective-C RTCMediaStreamTrack

Update API for Objective-C RTCMediaStreamTrack.

R=tkchin@webrtc.org

Committed: https://crrev.com/81028796bc5b359c44a0b4a9d85c55e5db41f833
Patch from Jon Hjelle <hjon@andyet.net>;.

Cr-Commit-Position: refs/heads/master@{#11208}

[hjon, 2015-12-16 01:07:47]

Patchset #2 (id:20001) has been deleted

[hjon, 2015-12-16 01:08:24]

Description was changed from

==========
Add enum conversion and fill in some more pieces


Add the other RTCMediaStreamTrackState values and some comments


Update build files


Commit initial thoughts for the interface and implementation


Changes based on feedback


Minor changes noticed from GL tool and some visual inspection


Add comments to BUILD.gn about things we can't do yet


Update test file for line breaks


Add comment documentation; add implementation and test for initializing from C++
IceCandidate


Update build files based on what I know from feedback from the RTCIceServer CL


Add updated RTCIceCandidate


More Mac support removal


Remove Mac support for now


Add AVFoundation to BUILD.gn, too


Link needed framework


Add Mac support to base.gyp


Sort alphabetically


Update gyp files


Update api_tests.gyp file for prefix header renaming


Update BUILD.gn format


Updates from feedback


Remove a line I used when testing sorting


Update build files


Updates based on feedback


Small updates to RTCIceServer and RTCIceServerTests


Add implementation and tests for RTCIceServer

BUG=
==========

to

==========
Update API for Objective-C RTCMediaStream.
==========

[hjon, 2015-12-16 18:21:12]

Patchset #1 (id:1) has been deleted

[hjon, 2015-12-19 22:35:22]

Description was changed from

==========
Update API for Objective-C RTCMediaStream.
==========

to

==========
Update API for Objective-C RTCMediaStreamTrack.
==========

[hjon, 2015-12-20 23:22:36]

hjon@andyet.net changed reviewers:
+ tkchin@webrtc.org

[hjon, 2015-12-20 23:22:36]

I'm not thrilled about the naming for the enum conversion methods (same for
other CLs that have enum conversions), but I haven't thought of something better
yet. Thoughts?

[tkchin_webrtc, 2016-01-05 16:43:34]

https://codereview.webrtc.org/1527143002/diff/80001/webrtc/api/objc/RTCMediaS...
File webrtc/api/objc/RTCMediaStreamTrack+Private.h (right):

https://codereview.webrtc.org/1527143002/diff/80001/webrtc/api/objc/RTCMediaS...
webrtc/api/objc/RTCMediaStreamTrack+Private.h:32:
(rtc::scoped_refptr<webrtc::MediaStreamTrackInterface>)track;
NS_DESIGNATED_INITIALIZER

https://codereview.webrtc.org/1527143002/diff/80001/webrtc/api/objc/RTCMediaS...
File webrtc/api/objc/RTCMediaStreamTrack.h (right):

https://codereview.webrtc.org/1527143002/diff/80001/webrtc/api/objc/RTCMediaS...
webrtc/api/objc/RTCMediaStreamTrack.h:32: @property(nonatomic, copy, readonly)
NSString *kind;
ditto don't need copy+readonly, just readonly will do

https://codereview.webrtc.org/1527143002/diff/80001/webrtc/api/objc/RTCMediaS...
webrtc/api/objc/RTCMediaStreamTrack.h:35: @property(nonatomic, copy, readonly)
NSString *id;
Don't use reserved keywords as property names. Maybe trackId

https://codereview.webrtc.org/1527143002/diff/80001/webrtc/api/objc/RTCMediaS...
webrtc/api/objc/RTCMediaStreamTrack.h:38: @property(nonatomic, getter=isEnabled)
BOOL enabled;
Prob don't need special getter? Just call it isEnabled

https://codereview.webrtc.org/1527143002/diff/80001/webrtc/api/objc/RTCMediaS...
File webrtc/api/objc/RTCMediaStreamTrack.mm (right):

https://codereview.webrtc.org/1527143002/diff/80001/webrtc/api/objc/RTCMediaS...
webrtc/api/objc/RTCMediaStreamTrack.mm:58: - (instancetype)initWithTrack:
maybe initWithNativeTrack

https://codereview.webrtc.org/1527143002/diff/80001/webrtc/api/objc/RTCMediaS...
webrtc/api/objc/RTCMediaStreamTrack.mm:67: +
(webrtc::MediaStreamTrackInterface::TrackState)nativeTrackStateForObjCTrackState:
what I've been doing is appending "native"
e.g.
nativeTrackStateForState:
trackStateForNativeState:

Basically the odd thing out is the C++ stuff, so prefix that only.

https://codereview.webrtc.org/1527143002/diff/80001/webrtc/api/objc/RTCMediaS...
webrtc/api/objc/RTCMediaStreamTrack.mm:95: + (NSString
*)descriptionForObjCTrackState:
stringForState: or descriptionForState: (but keep it consistent in other files
too)
there might be cases where you will want stateForString: or stateForDescription:
in which case I'd lean towards stringForState/stateForString

[hjon, 2016-01-05 22:48:19]

https://codereview.webrtc.org/1527143002/diff/80001/webrtc/api/objc/RTCMediaS...
File webrtc/api/objc/RTCMediaStreamTrack+Private.h (right):

https://codereview.webrtc.org/1527143002/diff/80001/webrtc/api/objc/RTCMediaS...
webrtc/api/objc/RTCMediaStreamTrack+Private.h:32:
(rtc::scoped_refptr<webrtc::MediaStreamTrackInterface>)track;
On 2016/01/05 16:43:34, tkchin_webrtc wrote:
> NS_DESIGNATED_INITIALIZER

Done.

https://codereview.webrtc.org/1527143002/diff/80001/webrtc/api/objc/RTCMediaS...
File webrtc/api/objc/RTCMediaStreamTrack.h (right):

https://codereview.webrtc.org/1527143002/diff/80001/webrtc/api/objc/RTCMediaS...
webrtc/api/objc/RTCMediaStreamTrack.h:32: @property(nonatomic, copy, readonly)
NSString *kind;
On 2016/01/05 16:43:34, tkchin_webrtc wrote:
> ditto don't need copy+readonly, just readonly will do

Done.

https://codereview.webrtc.org/1527143002/diff/80001/webrtc/api/objc/RTCMediaS...
webrtc/api/objc/RTCMediaStreamTrack.h:35: @property(nonatomic, copy, readonly)
NSString *id;
On 2016/01/05 16:43:34, tkchin_webrtc wrote:
> Don't use reserved keywords as property names. Maybe trackId

Done.

https://codereview.webrtc.org/1527143002/diff/80001/webrtc/api/objc/RTCMediaS...
webrtc/api/objc/RTCMediaStreamTrack.h:38: @property(nonatomic, getter=isEnabled)
BOOL enabled;
On 2016/01/05 16:43:34, tkchin_webrtc wrote:
> Prob don't need special getter? Just call it isEnabled

Done.

https://codereview.webrtc.org/1527143002/diff/80001/webrtc/api/objc/RTCMediaS...
File webrtc/api/objc/RTCMediaStreamTrack.mm (right):

https://codereview.webrtc.org/1527143002/diff/80001/webrtc/api/objc/RTCMediaS...
webrtc/api/objc/RTCMediaStreamTrack.mm:58: - (instancetype)initWithTrack:
On 2016/01/05 16:43:34, tkchin_webrtc wrote:
> maybe initWithNativeTrack

Done.

https://codereview.webrtc.org/1527143002/diff/80001/webrtc/api/objc/RTCMediaS...
webrtc/api/objc/RTCMediaStreamTrack.mm:67: +
(webrtc::MediaStreamTrackInterface::TrackState)nativeTrackStateForObjCTrackState:
On 2016/01/05 16:43:34, tkchin_webrtc wrote:
> what I've been doing is appending "native"
> e.g.
> nativeTrackStateForState:
> trackStateForNativeState:
> 
> Basically the odd thing out is the C++ stuff, so prefix that only.

Done.

https://codereview.webrtc.org/1527143002/diff/80001/webrtc/api/objc/RTCMediaS...
webrtc/api/objc/RTCMediaStreamTrack.mm:95: + (NSString
*)descriptionForObjCTrackState:
On 2016/01/05 16:43:34, tkchin_webrtc wrote:
> stringForState: or descriptionForState: (but keep it consistent in other files
> too)
> there might be cases where you will want stateForString: or
stateForDescription:
> in which case I'd lean towards stringForState/stateForString

Done.

[tkchin_webrtc, 2016-01-06 19:30:52]

https://codereview.webrtc.org/1527143002/diff/100001/webrtc/api/objc/RTCMedia...
File webrtc/api/objc/RTCMediaStreamTrack.mm (right):

https://codereview.webrtc.org/1527143002/diff/100001/webrtc/api/objc/RTCMedia...
webrtc/api/objc/RTCMediaStreamTrack.mm:35: - (void)setIsEnabled:(BOOL)enabled {
isEnabled

https://codereview.webrtc.org/1527143002/diff/100001/webrtc/api/objc/RTCMedia...
webrtc/api/objc/RTCMediaStreamTrack.mm:49: self.readyState]];
move into a local first to avoid the weird indentation

https://codereview.webrtc.org/1527143002/diff/100001/webrtc/api/objc/RTCMedia...
webrtc/api/objc/RTCMediaStreamTrack.mm:95: + (NSString *)stringForState:
I think it fits on one line

[tkchin_webrtc, 2016-01-06 19:54:44]

lgtm

[tkchin_webrtc, 2016-01-06 20:48:02]

The CQ bit was checked by tkchin@webrtc.org

[tkchin_webrtc, 2016-01-06 20:48:02]

The patchset sent to the CQ was uploaded after l-g-t-m from tkchin@webrtc.org
Link to the patchset: https://codereview.webrtc.org/1527143002/#ps220001 (title:
"Alphabetical order")

[commit-bot: I haz the power, 2016-01-06 20:48:12]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1527143002/220001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1527143002/220001

[commit-bot: I haz the power, 2016-01-06 22:48:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-06 22:48:34]

Try jobs failed on following builders:
  android_arm64_rel on tryserver.webrtc (JOB_TIMED_OUT, no build URL)
  win_baremetal on tryserver.webrtc (JOB_TIMED_OUT, no build URL)

[tkchin_webrtc, 2016-01-11 21:16:23]

Description was changed from

==========
Update API for Objective-C RTCMediaStreamTrack.
==========

to

==========
Update API for Objective-C RTCMediaStreamTrack.

R=tkchin@webrtc.org

Committed:
https://chromium.googlesource.com/external/webrtc/+/81028796bc5b359c44a0b4a9d...
==========

[commit-bot: I haz the power, 2016-01-11 21:16:23]

Description was changed from

==========
Update API for Objective-C RTCMediaStreamTrack.

R=tkchin@webrtc.org

Committed:
https://chromium.googlesource.com/external/webrtc/+/81028796bc5b359c44a0b4a9d...
==========

to

==========
Update API for Objective-C RTCMediaStreamTrack.

R=tkchin@webrtc.org

Committed: https://crrev.com/81028796bc5b359c44a0b4a9d85c55e5db41f833
Patch from Jon Hjelle <hjon@andyet.net>.

Cr-Commit-Position: refs/heads/master@{#11208}
==========

[tkchin_webrtc, 2016-01-11 21:16:24]

Committed patchset #11 (id:240001) manually as
81028796bc5b359c44a0b4a9d85c55e5db41f833 (presubmit successful).

[commit-bot: I haz the power, 2016-01-11 21:16:24]

Patchset 11 (id:??) landed as
https://crrev.com/81028796bc5b359c44a0b4a9d85c55e5db41f833
Cr-Commit-Position: refs/heads/master@{#11208}