Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1361)

Unified Diff: webrtc/modules/rtp_rtcp/source/rtcp_receiver.h

Issue 1527003002: [rtp_rtcp] RtcpReceiverTest rewritten using public available interface (observers) instead intermid… (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: rebase Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/modules/rtp_rtcp/source/rtcp_receiver.h
diff --git a/webrtc/modules/rtp_rtcp/source/rtcp_receiver.h b/webrtc/modules/rtp_rtcp/source/rtcp_receiver.h
index 24861bd49e6aeb4963c2297b203bbdae4c550648..3c626a9d8134f3a927d064506ee136d1bb1df6f1 100644
--- a/webrtc/modules/rtp_rtcp/source/rtcp_receiver.h
+++ b/webrtc/modules/rtp_rtcp/source/rtcp_receiver.h
@@ -52,12 +52,7 @@ public:
uint32_t RelaySSRC() const;
- int32_t IncomingRTCPPacket(
- RTCPHelp::RTCPPacketInformation& rtcpPacketInformation,
- RTCPUtility::RTCPParserV2 *rtcpParser);
-
- void TriggerCallbacksFromRTCPPacket(
- RTCPHelp::RTCPPacketInformation& rtcpPacketInformation);
+ bool IncomingPacket(const uint8_t* buffer, size_t length);
// get received cname
int32_t CNAME(uint32_t remoteSSRC, char cName[RTCP_CNAME_SIZE]) const;
@@ -110,7 +105,14 @@ public:
void RegisterRtcpStatisticsCallback(RtcpStatisticsCallback* callback);
RtcpStatisticsCallback* GetRtcpStatisticsCallback();
-protected:
+ protected:
+ void IncomingRTCPPacket(
+ RTCPHelp::RTCPPacketInformation& rtcpPacketInformation,
+ RTCPUtility::RTCPParserV2* rtcpParser);
+
+ void TriggerCallbacksFromRTCPPacket(
+ RTCPHelp::RTCPPacketInformation& rtcpPacketInformation);
+
RTCPUtility::RTCPCnameInformation* CreateCnameInformation(uint32_t remoteSSRC);
RTCPUtility::RTCPCnameInformation* GetCnameInformation(
uint32_t remoteSSRC) const;

Powered by Google App Engine
This is Rietveld 408576698