[rtp_rtcp] RtcpReceiverTest rewritten using public available interface (observers) instead intermid…

[rtp_rtcp] RtcpReceiverTest rewritten using public available interface (observers) instead intermidiate structure

RtcpReceiver interface slightly changed: combining two functions to process RTCP packet is done now in RtcpReceiver instead of RtpRtcpModule.
Some packets couldn't be tested now because there result is unobservable (i.e. do not cause any special callbacks, do not change RtcpReceiver internal state).

BUG=webrtc:5260

[danilchap, 2015-12-15 21:54:44]

Description was changed from

==========
[rtp_rtcp] RtcpReceiverTest rewritten using public available interface
(observers) instead intermidiate structure

RtcpReceiver interface slightly changed: combining two functions to process RTCP
packet is done now in RtcpReceiver instead of RtpRtcpModule.
Some packets couldn't be tested now because there result is unobservable (i.e.
do not cause any special callbacks, do not change RtcpReceiver internal state).

BUG=webrtc:5260
R=åsapersson
==========

to

==========
[rtp_rtcp] RtcpReceiverTest rewritten using public available interface
(observers) instead intermidiate structure

RtcpReceiver interface slightly changed: combining two functions to process RTCP
packet is done now in RtcpReceiver instead of RtpRtcpModule.
Some packets couldn't be tested now because there result is unobservable (i.e.
do not cause any special callbacks, do not change RtcpReceiver internal state).

BUG=webrtc:5260
R=åsapersson
==========

[danilchap, 2016-02-03 16:36:37]

Description was changed from

==========
[rtp_rtcp] RtcpReceiverTest rewritten using public available interface
(observers) instead intermidiate structure

RtcpReceiver interface slightly changed: combining two functions to process RTCP
packet is done now in RtcpReceiver instead of RtpRtcpModule.
Some packets couldn't be tested now because there result is unobservable (i.e.
do not cause any special callbacks, do not change RtcpReceiver internal state).

BUG=webrtc:5260
R=åsapersson
==========

to

==========
[rtp_rtcp] RtcpReceiverTest rewritten using public available interface
(observers) instead intermidiate structure

RtcpReceiver interface slightly changed: combining two functions to process RTCP
packet is done now in RtcpReceiver instead of RtpRtcpModule.
Some packets couldn't be tested now because there result is unobservable (i.e.
do not cause any special callbacks, do not change RtcpReceiver internal state).

BUG=webrtc:5260
==========

[danilchap, 2016-02-03 16:36:37]

danilchap@webrtc.org changed reviewers:
- asapersson@webrtc.org

[danilchap, 2016-02-22 12:51:29]

danilchap@webrtc.org changed reviewers:
+ philipel@webrtc.org

[philipel, 2016-02-24 11:02:01]

https://codereview.webrtc.org/1527003002/diff/60001/webrtc/modules/rtp_rtcp/m...
File webrtc/modules/rtp_rtcp/mocks/mock_rtcp_observers.h (right):

https://codereview.webrtc.org/1527003002/diff/60001/webrtc/modules/rtp_rtcp/m...
webrtc/modules/rtp_rtcp/mocks/mock_rtcp_observers.h:2: *  Copyright (c) 2012 The
WebRTC project authors. All Rights Reserved.
2016 :)

https://codereview.webrtc.org/1527003002/diff/60001/webrtc/modules/rtp_rtcp/s...
File webrtc/modules/rtp_rtcp/source/rtcp_receiver.cc (right):

https://codereview.webrtc.org/1527003002/diff/60001/webrtc/modules/rtp_rtcp/s...
webrtc/modules/rtp_rtcp/source/rtcp_receiver.cc:292: if (!valid_rtcpheader) {
Replace with if(!rtcp_parser.IsValid()) and remove line 291.

[danilchap, 2016-02-24 12:53:11]

https://codereview.webrtc.org/1527003002/diff/60001/webrtc/modules/rtp_rtcp/m...
File webrtc/modules/rtp_rtcp/mocks/mock_rtcp_observers.h (right):

https://codereview.webrtc.org/1527003002/diff/60001/webrtc/modules/rtp_rtcp/m...
webrtc/modules/rtp_rtcp/mocks/mock_rtcp_observers.h:2: *  Copyright (c) 2012 The
WebRTC project authors. All Rights Reserved.
On 2016/02/24 11:02:01, philipel wrote:
> 2016 :)

Oops.

https://codereview.webrtc.org/1527003002/diff/60001/webrtc/modules/rtp_rtcp/s...
File webrtc/modules/rtp_rtcp/source/rtcp_receiver.cc (right):

https://codereview.webrtc.org/1527003002/diff/60001/webrtc/modules/rtp_rtcp/s...
webrtc/modules/rtp_rtcp/source/rtcp_receiver.cc:292: if (!valid_rtcpheader) {
On 2016/02/24 11:02:01, philipel wrote:
> Replace with if(!rtcp_parser.IsValid()) and remove line 291.

Actually yes: rtcp_parser do slightly more than validating first rtcp header. So
name is misleading.

[philipel, 2016-02-25 15:26:08]

On 2016/02/24 12:53:11, danilchap wrote:
>
https://codereview.webrtc.org/1527003002/diff/60001/webrtc/modules/rtp_rtcp/m...
> File webrtc/modules/rtp_rtcp/mocks/mock_rtcp_observers.h (right):
> 
>
https://codereview.webrtc.org/1527003002/diff/60001/webrtc/modules/rtp_rtcp/m...
> webrtc/modules/rtp_rtcp/mocks/mock_rtcp_observers.h:2: *  Copyright (c) 2012
The
> WebRTC project authors. All Rights Reserved.
> On 2016/02/24 11:02:01, philipel wrote:
> > 2016 :)
> 
> Oops.
> 
>
https://codereview.webrtc.org/1527003002/diff/60001/webrtc/modules/rtp_rtcp/s...
> File webrtc/modules/rtp_rtcp/source/rtcp_receiver.cc (right):
> 
>
https://codereview.webrtc.org/1527003002/diff/60001/webrtc/modules/rtp_rtcp/s...
> webrtc/modules/rtp_rtcp/source/rtcp_receiver.cc:292: if (!valid_rtcpheader) {
> On 2016/02/24 11:02:01, philipel wrote:
> > Replace with if(!rtcp_parser.IsValid()) and remove line 291.
> 
> Actually yes: rtcp_parser do slightly more than validating first rtcp header.
So
> name is misleading.

LGTM