Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Issue 1525983003: Fix HPF initialization behavior. (Closed)

Created:
5 years ago by the sun
Modified:
5 years ago
CC:
webrtc-reviews_webrtc.org, peah-webrtc, Andrew MacDonald, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, kwiberg-webrtc, minyue-webrtc, the sun, aluebs-webrtc, bjornv1
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Fix HPF initialization behavior. This was changed when removing the ProcessingComponent inheritance in https://codereview.webrtc.org/1490333004/. BUG=webrtc:5298 Committed: https://crrev.com/c1316a1e51231b717e335f2c4c5ed3bf860a42b3 Cr-Commit-Position: refs/heads/master@{#11038}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -0 lines) Patch
M webrtc/modules/audio_processing/high_pass_filter_impl.cc View 2 chunks +9 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
the sun
5 years ago (2015-12-15 14:33:29 UTC) #2
hlundin-webrtc
lgtm
5 years ago (2015-12-15 16:08:22 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1525983003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1525983003/1
5 years ago (2015-12-15 19:39:16 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_rel on tryserver.webrtc (JOB_TIMED_OUT, no build URL) linux_baremetal on ...
5 years ago (2015-12-15 21:39:35 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1525983003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1525983003/1
5 years ago (2015-12-15 22:12:38 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-16 00:07:29 UTC) #12
commit-bot: I haz the power
5 years ago (2015-12-16 00:07:40 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c1316a1e51231b717e335f2c4c5ed3bf860a42b3
Cr-Commit-Position: refs/heads/master@{#11038}

Powered by Google App Engine
This is Rietveld 408576698