Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(335)

Unified Diff: webrtc/api/objc/RTCSessionDescription.h

Issue 1524303006: Update API for Objective-C RTCSessionDescription. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@updateRTCIceCandidate
Patch Set: Rebase and add tests Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/api/objc/RTCSessionDescription.h
diff --git a/webrtc/base/objc/NSString+StdString.h b/webrtc/api/objc/RTCSessionDescription.h
similarity index 53%
copy from webrtc/base/objc/NSString+StdString.h
copy to webrtc/api/objc/RTCSessionDescription.h
index 8bf6cc94be0346e398ab1a980af6378f06ccb7a5..8b881d60b2cde714828888de86ae83c086f00e55 100644
--- a/webrtc/base/objc/NSString+StdString.h
+++ b/webrtc/api/objc/RTCSessionDescription.h
@@ -10,16 +10,20 @@
#import <Foundation/Foundation.h>
-#include <string>
-
NS_ASSUME_NONNULL_BEGIN
-@interface NSString (StdString)
+@interface RTCSessionDescription : NSObject
+
+/** The type of session description. */
+@property(nonatomic, copy, readonly) NSString *type;
tkchin_webrtc 2016/01/05 16:29:18 copy is technically for setters only. Since we're
hjon 2016/01/05 22:16:20 Done.
+
+/** The SDP string representation of this session description. */
+@property(nonatomic, copy, readonly) NSString *sdp;
-@property(nonatomic, readonly) std::string stdString;
+- (instancetype)init NS_UNAVAILABLE;
-+ (std::string)stdStringForString:(NSString *)nsString;
-+ (NSString *)stringForStdString:(const std::string&)stdString;
+/** Initialize a session description with a type and SDP string. */
+- (instancetype)initWithType:(NSString *)type sdp:(NSString *)sdp;
@end

Powered by Google App Engine
This is Rietveld 408576698