Make LevelEstimation not a ProcessingComponent.

Make LevelEstimation not a ProcessingComponent.

BUG=webrtc:5355
Committed: https://crrev.com/949028fbf1e9a01fb96b186b95606c0096e7d13f
Cr-Commit-Position: refs/heads/master@{#11033}

[the sun, 2015-12-11 23:13:33]

solenberg@webrtc.org changed reviewers:
+ peah@webrtc.org

[the sun, 2015-12-11 23:36:21]

Description was changed from

==========
Make LevelEstimation not a ProcessingComponent.

BUG=webrtc:5355
==========

to

==========
Make LevelEstimation not a ProcessingComponent.

BUG=webrtc:5355
==========

[the sun, 2015-12-11 23:36:21]

solenberg@webrtc.org changed reviewers:
- peah@webrtc.org

[the sun, 2015-12-11 23:58:41]

solenberg@webrtc.org changed reviewers:
+ peah@webrtc.org

[the sun, 2015-12-15 09:25:32]

On 2015/12/11 23:13:33, the sun wrote:

ping...

[hlundin-webrtc, 2015-12-15 10:07:57]

henrik.lundin@webrtc.org changed reviewers:
+ henrik.lundin@webrtc.org

[hlundin-webrtc, 2015-12-15 10:07:57]

Drive-by LGTM, with one nit.

https://codereview.webrtc.org/1523483002/diff/20001/webrtc/modules/audio_proc...
File webrtc/modules/audio_processing/level_estimator_impl.cc (right):

https://codereview.webrtc.org/1523483002/diff/20001/webrtc/modules/audio_proc...
webrtc/modules/audio_processing/level_estimator_impl.cc:38: for (int i = 0; i <
audio->num_channels(); i++) {
Out of curiosity, why did you change from ++i to i++?

https://codereview.webrtc.org/1523483002/diff/20001/webrtc/modules/audio_proc...
webrtc/modules/audio_processing/level_estimator_impl.cc:60: return
AudioProcessing::kNotEnabledError;;
The number of semicolons is too high.

[the sun, 2015-12-15 12:08:45]

https://codereview.webrtc.org/1523483002/diff/20001/webrtc/modules/audio_proc...
File webrtc/modules/audio_processing/level_estimator_impl.cc (right):

https://codereview.webrtc.org/1523483002/diff/20001/webrtc/modules/audio_proc...
webrtc/modules/audio_processing/level_estimator_impl.cc:38: for (int i = 0; i <
audio->num_channels(); i++) {
On 2015/12/15 10:07:57, hlundin-webrtc wrote:
> Out of curiosity, why did you change from ++i to i++?

I just did a side-by-side with another module and made it the same.

https://codereview.webrtc.org/1523483002/diff/20001/webrtc/modules/audio_proc...
webrtc/modules/audio_processing/level_estimator_impl.cc:60: return
AudioProcessing::kNotEnabledError;;
On 2015/12/15 10:07:57, hlundin-webrtc wrote:
> The number of semicolons is too high.

Done.

[the sun, 2015-12-15 13:47:26]

The CQ bit was checked by solenberg@webrtc.org

[the sun, 2015-12-15 13:47:27]

The patchset sent to the CQ was uploaded after l-g-t-m from
henrik.lundin@webrtc.org
Link to the patchset: https://codereview.webrtc.org/1523483002/#ps40001 (title:
"comments")

[commit-bot: I haz the power, 2015-12-15 13:47:32]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1523483002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1523483002/40001

[commit-bot: I haz the power, 2015-12-15 15:47:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-12-15 15:47:50]

Try jobs failed on following builders:
  android_arm64_rel on tryserver.webrtc (JOB_TIMED_OUT, no build URL)
  linux_baremetal on tryserver.webrtc (JOB_TIMED_OUT, no build URL)
  mac_baremetal on tryserver.webrtc (JOB_TIMED_OUT, no build URL)
  win_baremetal on tryserver.webrtc (JOB_TIMED_OUT, no build URL)

[the sun, 2015-12-15 19:37:44]

The CQ bit was checked by solenberg@webrtc.org

[commit-bot: I haz the power, 2015-12-15 19:37:56]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1523483002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1523483002/40001

[commit-bot: I haz the power, 2015-12-15 19:39:43]

Description was changed from

==========
Make LevelEstimation not a ProcessingComponent.

BUG=webrtc:5355
==========

to

==========
Make LevelEstimation not a ProcessingComponent.

BUG=webrtc:5355
==========

[commit-bot: I haz the power, 2015-12-15 19:39:44]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-12-15 19:39:54]

Description was changed from

==========
Make LevelEstimation not a ProcessingComponent.

BUG=webrtc:5355
==========

to

==========
Make LevelEstimation not a ProcessingComponent.

BUG=webrtc:5355

Committed: https://crrev.com/949028fbf1e9a01fb96b186b95606c0096e7d13f
Cr-Commit-Position: refs/heads/master@{#11033}
==========

[commit-bot: I haz the power, 2015-12-15 19:39:55]

Patchset 3 (id:??) landed as
https://crrev.com/949028fbf1e9a01fb96b186b95606c0096e7d13f
Cr-Commit-Position: refs/heads/master@{#11033}