Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(90)

Issue 1523323002: Fix NoiseSuppression initialization behavior. (Closed)

Created:
5 years ago by the sun
Modified:
5 years ago
Reviewers:
hlundin-webrtc
CC:
webrtc-reviews_webrtc.org, peah-webrtc, Andrew MacDonald, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, kwiberg-webrtc, minyue-webrtc, the sun, aluebs-webrtc, bjornv1
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Fix NoiseSuppression initialization behavior. This was changed when removing the ProcessingComponent inheritance in https://codereview.webrtc.org/1507683006/. BUG=webrtc:5298 Committed: https://crrev.com/29e2f9385b7e0dde4af7317af5cd0ce6adf1ee9d Cr-Commit-Position: refs/heads/master@{#11043}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -14 lines) Patch
M webrtc/modules/audio_processing/noise_suppression_impl.h View 2 chunks +4 lines, -2 lines 0 comments Download
M webrtc/modules/audio_processing/noise_suppression_impl.cc View 5 chunks +18 lines, -12 lines 0 comments Download

Messages

Total messages: 18 (9 generated)
the sun
5 years ago (2015-12-15 16:16:03 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1523323002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1523323002/1
5 years ago (2015-12-15 19:40:43 UTC) #5
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: android_arm64_rel on tryserver.webrtc (JOB_TIMED_OUT, no build URL) ...
5 years ago (2015-12-15 21:41:04 UTC) #7
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1523323002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1523323002/1
5 years ago (2015-12-16 09:09:18 UTC) #9
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years ago (2015-12-16 09:10:19 UTC) #11
hlundin-webrtc
lgtm
5 years ago (2015-12-16 09:12:30 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1523323002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1523323002/1
5 years ago (2015-12-16 09:16:58 UTC) #14
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-16 09:18:19 UTC) #16
commit-bot: I haz the power
5 years ago (2015-12-16 09:18:31 UTC) #18
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/29e2f9385b7e0dde4af7317af5cd0ce6adf1ee9d
Cr-Commit-Position: refs/heads/master@{#11043}

Powered by Google App Engine
This is Rietveld 408576698