talk/app/webrtc/rtpsender.cc - Issue 1522903002: Add a 'remote' property to MediaSourceInterface. Also adding an implementation to the relevant sour…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: talk/app/webrtc/rtpsender.cc

Issue 1522903002: Add a 'remote' property to MediaSourceInterface. Also adding an implementation to the relevant sour… (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: Address comments Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: talk/app/webrtc/rtpsender.cc

diff --git a/talk/app/webrtc/rtpsender.cc b/talk/app/webrtc/rtpsender.cc

index ea10b7b33f9b4e6ef3f92c8e5eab6124b2ac816b..c0d23a0503cc08fb5a7fd8b301f8bd99bf076bd8 100644

--- a/talk/app/webrtc/rtpsender.cc

+++ b/talk/app/webrtc/rtpsender.cc

@@ -184,7 +184,8 @@ void AudioRtpSender::Stop() {

void AudioRtpSender::SetAudioSend() {

RTC_DCHECK(!stopped_ && can_send_track());

cricket::AudioOptions options;

- if (track_->enabled() && track_->GetSource()) {

+ if (track_->enabled() && track_->GetSource() &&

+ !track_->GetSource()->remote()) {

// TODO(xians): Remove this static_cast since we should be able to connect

// a remote audio track to a peer connection.

options = static_cast<LocalAudioSource*>(track_->GetSource())->options();

« no previous file with comments | « talk/app/webrtc/rtpreceiver.cc ('k') | talk/app/webrtc/rtpsenderreceiver_unittest.cc » ('j') | no next file with comments »