Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(168)

Issue 1520493003: Fix -Wformat error in Win-Clang build (take 2) (Closed)

Created:
5 years ago by hans
Modified:
5 years ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Fix -Wformat error in Win-Clang build (take 2) I managed to cast the wrong parameter in #10982 :-( BUG=82385 Committed: https://crrev.com/55bcf0f087cf01dfd6230b02a665d2a88fb9d150 Cr-Commit-Position: refs/heads/master@{#10983}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M webrtc/base/event_tracer.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (7 generated)
hans
See https://codereview.webrtc.org/1514253002 for take 1.
5 years ago (2015-12-11 02:30:28 UTC) #1
aluebs-webrtc
+niklas.enbom, who LGTMd and committed take 1.
5 years ago (2015-12-11 02:50:19 UTC) #5
pthatcher1
lgtm
5 years ago (2015-12-11 02:52:18 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1520493003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1520493003/1
5 years ago (2015-12-11 02:52:36 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-11 03:49:26 UTC) #11
commit-bot: I haz the power
5 years ago (2015-12-11 03:49:39 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/55bcf0f087cf01dfd6230b02a665d2a88fb9d150
Cr-Commit-Position: refs/heads/master@{#10983}

Powered by Google App Engine
This is Rietveld 408576698