talk/app/webrtc/androidtests/src/org/webrtc/SurfaceTextureHelperTest.java - Issue 1520243003: Android: Refactor renderers to allow apps to inject custom shaders

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: talk/app/webrtc/androidtests/src/org/webrtc/SurfaceTextureHelperTest.java

Issue 1520243003: Android: Refactor renderers to allow apps to inject custom shaders (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: Address Nisses comments Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « talk/app/webrtc/androidtests/src/org/webrtc/GlRectDrawerTest.java ('k') | talk/app/webrtc/java/android/org/webrtc/EglBase.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: talk/app/webrtc/androidtests/src/org/webrtc/SurfaceTextureHelperTest.java

diff --git a/talk/app/webrtc/androidtests/src/org/webrtc/SurfaceTextureHelperTest.java b/talk/app/webrtc/androidtests/src/org/webrtc/SurfaceTextureHelperTest.java

index 1a6731b67c8dd81de3902bd7a1feaea221fb3764..9e0164d4b836891382729af8e6d81a8e662341e4 100644

--- a/talk/app/webrtc/androidtests/src/org/webrtc/SurfaceTextureHelperTest.java

+++ b/talk/app/webrtc/androidtests/src/org/webrtc/SurfaceTextureHelperTest.java

@@ -149,7 +149,7 @@ public final class SurfaceTextureHelperTest extends ActivityTestCase {

// Wait for an OES texture to arrive and draw it onto the pixel buffer.

listener.waitForNewFrame();

eglBase.makeCurrent();

- drawer.drawOes(listener.oesTextureId, listener.transformMatrix);

+ drawer.drawOes(listener.oesTextureId, listener.transformMatrix, 0, 0, width, height);

surfaceTextureHelper.returnTextureFrame();

@@ -220,7 +220,7 @@ public final class SurfaceTextureHelperTest extends ActivityTestCase {

// Draw the pending texture frame onto the pixel buffer.

eglBase.makeCurrent();

final GlRectDrawer drawer = new GlRectDrawer();

- drawer.drawOes(listener.oesTextureId, listener.transformMatrix);

+ drawer.drawOes(listener.oesTextureId, listener.transformMatrix, 0, 0, width, height);

drawer.release();

// Download the pixels in the pixel buffer as RGBA. Not all platforms support RGB, e.g. Nexus 9.