Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(205)

Issue 1519503002: [rtp_rtcp] lint errors about rand() usage fixed. (Closed)

Created:
5 years ago by danilchap
Modified:
5 years ago
Reviewers:
mflodman
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, zhuangzesen_agora.io, stefan-webrtc, mflodman
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

[rtp_rtcp] lint errors about rand() usage fixed. rand() usage replaced with new Random class, which also makes it clearer what interval random number is in. BUG=webrtc:5277 R=mflodman Committed: https://crrev.com/47a740bc5e36bcaf19385f9d4c0afb0cad070a05 Cr-Commit-Position: refs/heads/master@{#11019}

Patch Set 1 #

Patch Set 2 : test/BWEStandAlone subfolder excluded because should be deleted #

Patch Set 3 : rebase #

Patch Set 4 : #

Patch Set 5 : rebase #

Patch Set 6 : #

Patch Set 7 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+62 lines, -66 lines) Patch
M webrtc/modules/rtp_rtcp/source/rtcp_sender.h View 2 chunks +2 lines, -0 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtcp_sender.cc View 4 chunks +8 lines, -11 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_fec_unittest.cc View 1 2 3 6 5 chunks +16 lines, -13 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_sender.h View 3 chunks +2 lines, -2 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_sender.cc View 5 chunks +6 lines, -6 lines 0 comments Download
M webrtc/modules/rtp_rtcp/test/testFec/test_fec.cc View 1 2 3 4 5 6 10 chunks +28 lines, -34 lines 0 comments Download

Messages

Total messages: 22 (11 generated)
danilchap
5 years ago (2015-12-10 14:02:15 UTC) #1
mflodman
LGTM
5 years ago (2015-12-14 12:22:27 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1519503002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1519503002/40001
5 years ago (2015-12-14 12:24:09 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: win_compile_dbg on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/win_compile_dbg/builds/1854)
5 years ago (2015-12-14 12:30:25 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1519503002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1519503002/60001
5 years ago (2015-12-14 15:33:24 UTC) #9
commit-bot: I haz the power
Exceeded global retry quota
5 years ago (2015-12-14 15:34:02 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1519503002/140001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1519503002/140001
5 years ago (2015-12-14 19:12:30 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: linux_baremetal on tryserver.webrtc (JOB_TIMED_OUT, no build URL) mac_baremetal on ...
5 years ago (2015-12-14 21:12:46 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1519503002/140001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1519503002/140001
5 years ago (2015-12-15 08:26:37 UTC) #19
commit-bot: I haz the power
Committed patchset #7 (id:140001)
5 years ago (2015-12-15 08:30:11 UTC) #20
commit-bot: I haz the power
5 years ago (2015-12-15 08:30:20 UTC) #22
Message was sent while issue was closed.
Patchset 7 (id:??) landed as
https://crrev.com/47a740bc5e36bcaf19385f9d4c0afb0cad070a05
Cr-Commit-Position: refs/heads/master@{#11019}

Powered by Google App Engine
This is Rietveld 408576698