Add VP8 and H264 depacketizer fuzzers.

webrtc/test/fuzzers/BUILD.gn

 # Copyright (c) 2015 The WebRTC project authors. All Rights Reserved.
 #
 # Use of this source code is governed by a BSD-style license
 # that can be found in the LICENSE file in the root of the source
 # tree. An additional intellectual property rights grant can be found
 # in the file PATENTS.  All contributing project authors may
 # be found in the AUTHORS file in the root of the source tree.
 
 import("//build/config/features.gni")
 import("//testing/test.gni")
 
 static_library("webrtc_fuzzer_main") {
   public_configs = [ "../..:common_inherited_config" ]
   sources = [
     "webrtc_fuzzer_main.cc",
   ]
   deps = [
     "../../system_wrappers:field_trial_default",

[kjellander_webrtc, 2015/12/14 07:11:37]

If you do the change in webrtc/test/BUILD.gn, shouldn't you include the fuzzers
as dependencies here to ensure they're built?

[pbos-webrtc, 2015/12/14 13:07:02]

I assume you mean webrtc/BUILD.gn. No fuzzer target will be built by default,
because we don't want to maintain a list of targets in this file (but rather
compile them all). This list of targets is already outdated and easy to miss.

This is what Chromium's libfuzzer bot does today (discovers targets using gn
refs).

     "../../system_wrappers:metrics_default",
     "//testing/libfuzzer:libfuzzer_main",
   ]
 }
 
-test("vp9_depacketizer_fuzzer") {
+test("vp8_qp_parser_fuzzer") {
   sources = [
-    "vp9_depacketizer_fuzzer.cc",
+    "vp8_qp_parser_fuzzer.cc",
   ]
   deps = [
     ":webrtc_fuzzer_main",
+    "../../modules/video_coding/",
+  ]
+
+  if (is_clang) {

[kjellander_webrtc, 2015/12/14 07:11:37]

Please can you fix the warnings and remove this instead? Applies below as well.

[pbos-webrtc, 2015/12/14 13:07:02]

Nope, it's not in these files, but video_coding isn't find_bad_constructs clean.
All depending targets have to suppress this warning. :(

+    # Suppress warnings from Chrome's Clang plugins.
+    # See http://code.google.com/p/webrtc/issues/detail?id=163 for details.
+    configs -= [ "//build/config/clang:find_bad_constructs" ]
+  }
+}
+
+test("vp8_depacketizer_fuzzer") {
+  sources = [
+    "vp8_depacketizer_fuzzer.cc",
+  ]
+  deps = [
+    ":webrtc_fuzzer_main",
     "../../modules/rtp_rtcp",
   ]
   if (is_clang) {
     # Suppress warnings from Chrome's Clang plugins.
     # See http://code.google.com/p/webrtc/issues/detail?id=163 for details.
     configs -= [ "//build/config/clang:find_bad_constructs" ]
   }
 }
 
-test("vp8_qp_parser_fuzzer") {
+test("h264_depacketizer_fuzzer") {
   sources = [
-    "vp8_qp_parser_fuzzer.cc",
+    "h264_depacketizer_fuzzer.cc",
   ]
   deps = [
     ":webrtc_fuzzer_main",
-    "../../modules/video_coding/",
+    "../../modules/rtp_rtcp",
   ]
-
   if (is_clang) {
     # Suppress warnings from Chrome's Clang plugins.
     # See http://code.google.com/p/webrtc/issues/detail?id=163 for details.
+    configs -= [ "//build/config/clang:find_bad_constructs" ]
+  }
+}
+
+test("vp9_depacketizer_fuzzer") {
+  sources = [
+    "vp9_depacketizer_fuzzer.cc",
+  ]
+  deps = [
+    ":webrtc_fuzzer_main",
+    "../../modules/rtp_rtcp",
+  ]
+  if (is_clang) {
+    # Suppress warnings from Chrome's Clang plugins.
+    # See http://code.google.com/p/webrtc/issues/detail?id=163 for details.
     configs -= [ "//build/config/clang:find_bad_constructs" ]
   }
 }
 
 source_set("audio_decoder_fuzzer") {
   sources = [
     "audio_decoder_fuzzer.cc",
     "audio_decoder_fuzzer.h",
   ]
   deps = [
@@ skipping 33 matching lines @@
 
 test("audio_decoder_opus_fuzzer") {
   sources = [
     "audio_decoder_opus_fuzzer.cc",
   ]
   deps = [
     ":audio_decoder_fuzzer",
     "../../modules/audio_coding:webrtc_opus",
   ]
 }