Fix build on clang/win.

Remove pointless move() to fix build on clang/win.

Fixes:
..\..\third_party\libjingle\source\talk\app\webrtc\remoteaudiosource.cc(100,15)
: error: moving a temporary object prevents copy elision
[-Werror,-Wpessimizing-move]
        ssrc, std::move(rtc::scoped_ptr<AudioSinkInterface>(new Sink(this))));
              ^
..\..\third_party\libjingle\source\talk\app\webrtc\remoteaudiosource.cc(100,15)
:  note: remove std::move call here
        ssrc, std::move(rtc::scoped_ptr<AudioSinkInterface>(new Sink(this))));
              ^~~~~~~~~~

R=thakis@chromium.org
TBR=thakis@chromium.org

Committed: https://crrev.com/cb95f54ee469cd9682ffecd404d37c5e4d58edb0
Cr-Commit-Position: refs/heads/master@{#10999}

[tommi, 2015-12-12 15:25:07]

Description was changed from

==========
Fix build on clang/win.

BUG=
==========

to

==========
Fix build on clang/win.

TBR=thakis@chromium.org
==========

[tommi, 2015-12-12 15:25:07]

tommi@webrtc.org changed reviewers:
+ thakis@chromium.org

[tommi, 2015-12-12 15:25:11]

The CQ bit was checked by tommi@webrtc.org

[commit-bot: I haz the power, 2015-12-12 15:25:13]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1517253004/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1517253004/1

[Nico, 2015-12-12 15:27:26]

I think a better CL description would be "remove pointless move()", but other
than that lgtm.

(maybe popularize https://www.chromium.org/rvalue-references on the webrtc
mailing list a bit – this mistake shows a pretty basic misunderstanding how
move-only types work :-/)

[Nico, 2015-12-12 15:31:09]

Description was changed from

==========
Fix build on clang/win.

TBR=thakis@chromium.org
==========

to

==========
Remove pointless move() to fix build on clang/win.

Fixes:
..\..\third_party\libjingle\source\talk\app\webrtc\remoteaudiosource.cc(100,15)
: error: moving a temporary object prevents copy elision
[-Werror,-Wpessimizing-move]
        ssrc, std::move(rtc::scoped_ptr<AudioSinkInterface>(new Sink(this))));
              ^
..\..\third_party\libjingle\source\talk\app\webrtc\remoteaudiosource.cc(100,15)
:  note: remove std::move call here
        ssrc, std::move(rtc::scoped_ptr<AudioSinkInterface>(new Sink(this))));
              ^~~~~~~~~~                      
TBR=thakis@chromium.org
==========

[tommi, 2015-12-12 15:33:55]

On 2015/12/12 15:27:26, Nico wrote:
> I think a better CL description would be "remove pointless move()", but other
> than that lgtm.
> 
> (maybe popularize https://www.chromium.org/rvalue-references on the webrtc
> mailing list a bit – this mistake shows a pretty basic misunderstanding how
> move-only types work :-/)

Ah, nah, this was my fault. I had a variable there first and somehow left the
std::move in there.

[tommi, 2015-12-12 15:54:46]

Description was changed from

==========
Remove pointless move() to fix build on clang/win.

Fixes:
..\..\third_party\libjingle\source\talk\app\webrtc\remoteaudiosource.cc(100,15)
: error: moving a temporary object prevents copy elision
[-Werror,-Wpessimizing-move]
        ssrc, std::move(rtc::scoped_ptr<AudioSinkInterface>(new Sink(this))));
              ^
..\..\third_party\libjingle\source\talk\app\webrtc\remoteaudiosource.cc(100,15)
:  note: remove std::move call here
        ssrc, std::move(rtc::scoped_ptr<AudioSinkInterface>(new Sink(this))));
              ^~~~~~~~~~                      
TBR=thakis@chromium.org
==========

to

==========
Remove pointless move() to fix build on clang/win.

Fixes:
..\..\third_party\libjingle\source\talk\app\webrtc\remoteaudiosource.cc(100,15)
: error: moving a temporary object prevents copy elision
[-Werror,-Wpessimizing-move]
        ssrc, std::move(rtc::scoped_ptr<AudioSinkInterface>(new Sink(this))));
              ^
..\..\third_party\libjingle\source\talk\app\webrtc\remoteaudiosource.cc(100,15)
:  note: remove std::move call here
        ssrc, std::move(rtc::scoped_ptr<AudioSinkInterface>(new Sink(this))));
              ^~~~~~~~~~

R=thakis@chromium.org
TBR=thakis@chromium.org

Committed:
https://chromium.googlesource.com/external/webrtc/+/cb95f54ee469cd9682ffecd40...
==========

[commit-bot: I haz the power, 2015-12-12 15:54:46]

Description was changed from

==========
Remove pointless move() to fix build on clang/win.

Fixes:
..\..\third_party\libjingle\source\talk\app\webrtc\remoteaudiosource.cc(100,15)
: error: moving a temporary object prevents copy elision
[-Werror,-Wpessimizing-move]
        ssrc, std::move(rtc::scoped_ptr<AudioSinkInterface>(new Sink(this))));
              ^
..\..\third_party\libjingle\source\talk\app\webrtc\remoteaudiosource.cc(100,15)
:  note: remove std::move call here
        ssrc, std::move(rtc::scoped_ptr<AudioSinkInterface>(new Sink(this))));
              ^~~~~~~~~~                      
TBR=thakis@chromium.org
==========

to

==========
Remove pointless move() to fix build on clang/win.

Fixes:
..\..\third_party\libjingle\source\talk\app\webrtc\remoteaudiosource.cc(100,15)
: error: moving a temporary object prevents copy elision
[-Werror,-Wpessimizing-move]
        ssrc, std::move(rtc::scoped_ptr<AudioSinkInterface>(new Sink(this))));
              ^
..\..\third_party\libjingle\source\talk\app\webrtc\remoteaudiosource.cc(100,15)
:  note: remove std::move call here
        ssrc, std::move(rtc::scoped_ptr<AudioSinkInterface>(new Sink(this))));
              ^~~~~~~~~~

R=thakis@chromium.org
TBR=thakis@chromium.org

Committed: https://crrev.com/cb95f54ee469cd9682ffecd404d37c5e4d58edb0
Cr-Commit-Position: refs/heads/master@{#10999}
==========

[commit-bot: I haz the power, 2015-12-12 15:54:46]

Patchset 1 (id:??) landed as
https://crrev.com/cb95f54ee469cd9682ffecd404d37c5e4d58edb0
Cr-Commit-Position: refs/heads/master@{#10999}

[tommi, 2015-12-12 15:54:47]

Committed patchset #1 (id:1) manually as
cb95f54ee469cd9682ffecd404d37c5e4d58edb0 (presubmit successful).