webrtc/p2p/base/transportcontroller_unittest.cc - Issue 1516993002: Properly handle different transports having different SSL roles.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/p2p/base/transportcontroller_unittest.cc

Issue 1516993002: Properly handle different transports having different SSL roles. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: Adding a helper method for GetSslRole, and some more comments. Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: webrtc/p2p/base/transportcontroller_unittest.cc

diff --git a/webrtc/p2p/base/transportcontroller_unittest.cc b/webrtc/p2p/base/transportcontroller_unittest.cc

index 140852984a63a72f63d2c2be03e8f58266770832..6ff158e8fc4e8d86ed8e5e16075c0980f0a92762 100644

--- a/webrtc/p2p/base/transportcontroller_unittest.cc

+++ b/webrtc/p2p/base/transportcontroller_unittest.cc

@@ -262,7 +262,8 @@ TEST_F(TransportControllerTest, TestGetSslRole) {

ASSERT_NE(nullptr, channel);

ASSERT_TRUE(channel->SetSslRole(rtc::SSL_CLIENT));

rtc::SSLRole role;

- EXPECT_TRUE(transport_controller_->GetSslRole(&role));

+ EXPECT_FALSE(transport_controller_->GetSslRole("video", &role));

+ EXPECT_TRUE(transport_controller_->GetSslRole("audio", &role));

EXPECT_EQ(rtc::SSL_CLIENT, role);

}

« no previous file with comments | « webrtc/p2p/base/transportcontroller.cc ('k') | no next file » | no next file with comments »