talk/app/webrtc/webrtcsession.h - Issue 1516993002: Properly handle different transports having different SSL roles.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: talk/app/webrtc/webrtcsession.h

Issue 1516993002: Properly handle different transports having different SSL roles. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: Adding a helper method for GetSslRole, and some more comments. Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: talk/app/webrtc/webrtcsession.h

diff --git a/talk/app/webrtc/webrtcsession.h b/talk/app/webrtc/webrtcsession.h

index dd5ca1811d45de5da7aaa078b40f5dfd60ea8c7f..b79e0ec270544664d538a394871241c916850492 100644

--- a/talk/app/webrtc/webrtcsession.h

+++ b/talk/app/webrtc/webrtcsession.h

@@ -204,7 +204,11 @@ class WebRtcSession : public AudioProviderInterface,

cricket::SecurePolicy SdesPolicy() const;

// Get current ssl role from transport.

- bool GetSslRole(rtc::SSLRole* role);

+ bool GetSslRole(const std::string& transport_name, rtc::SSLRole* role);

+ // Get current SSL role for this channel's transport.

+ // If |transport| is null, returns false.

+ bool GetSslRole(const cricket::BaseChannel* channel, rtc::SSLRole* role);

void CreateOffer(

CreateSessionDescriptionObserver* observer,

« no previous file with comments | « talk/app/webrtc/peerconnectioninterface_unittest.cc ('k') | talk/app/webrtc/webrtcsession.cc » ('j') | no next file with comments »