Properly handle different transports having different SSL roles.

talk/session/media/mediasession.h

 /*
  * libjingle
  * Copyright 2004 Google Inc.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are met:
  *
  *  1. Redistributions of source code must retain the above copyright notice,
  *     this list of conditions and the following disclaimer.
  *  2. Redistributions in binary form must reproduce the above copyright notice,
@@ skipping 126 matching lines @@
   bool recv_audio;
   bool recv_video;
   DataChannelType data_channel_type;
   bool is_muc;
   bool vad_enabled;
   bool rtcp_mux_enabled;
   bool bundle_enabled;
   // bps. -1 == auto.
   int video_bandwidth;
   int data_bandwidth;
-  TransportOptions transport_options;
+  TransportOptions audio_transport_options;
+  TransportOptions video_transport_options;
+  TransportOptions data_transport_options;

[pthatcher1, 2015/12/11 03:16:09]

At first pass, this feels ugly, especially if we want to move to having Unified
Plan and having multiple audio, video, and data transports.  If anything, this
should be a vector of (transport_name, transport_options).

It also feels ugly for the bundle case, where there aren't separate audio,
video, and data transports.  

Could you try with a vector/map approach and see where that heads?


I also have been reluctant to approve https://codereview.webrtc.org/1453813005/
for the same reason, but I hadn't yet thought of a good way to approach it.  I
think a vector/map of options keyed by transport name is a good thing to try.

[Taylor Brandstetter, 2015/12/11 18:40:02]

I had the same thought. But my reasons for not doing a map were:

* It would be inconsistent with the current form of MediaSessionOptions (we
already have recv_audio/recv_video, video_bandwidth/data_bandwidth, etc.)
* It seems like it would be really messy to get the content name propagated to
the right places with the current status of our code.

But I'll try, and see where it heads.

 
   struct Stream {
     Stream(MediaType type,
            const std::string& id,
            const std::string& sync_label,
            int num_sim_layers)
         : type(type), id(id), sync_label(sync_label),
           num_sim_layers(num_sim_layers) {
     }
     MediaType type;
@@ skipping 394 matching lines @@
 void GetSupportedVideoCryptoSuiteNames(
     std::vector<std::string>* crypto_suite_names);
 void GetSupportedDataCryptoSuiteNames(
     std::vector<std::string>* crypto_suite_names);
 void GetDefaultSrtpCryptoSuiteNames(
     std::vector<std::string>* crypto_suite_names);
 
 }  // namespace cricket
 
 #endif  // TALK_SESSION_MEDIA_MEDIASESSION_H_