Reland of Free SCTP data channels asynchronously in PeerConnection.

Reland of Free SCTP data channels asynchronously in PeerConnection. (patchset #1 id:1 of https://codereview.webrtc.org/1513143003/ )

Original issue's description:
> Revert of Free SCTP data channels asynchronously in PeerConnection. (patchset #3 id:40001 of https://codereview.webrtc.org/1492383002/ )
>
> Reason for revert:
> Breaks WebrtcTransportTest.DataStream, due to different rtc::Thread implementation on Chromium.
>
> Original issue's description:
> > Free SCTP data channels asynchronously in PeerConnection.
> >
> > This is needed so that the data channel isn't deleted while one of its
> > own methods is on the call stack.
> >
> > BUG=565048
> >
> > Committed: https://crrev.com/386869247f28e72a00307a1b5c92465eea343ad2
> > Cr-Commit-Position: refs/heads/master@{#10923}
>
> TBR=pthatcher@webrtc.org
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=565048
>
> Committed: https://crrev.com/a1f567ae9012a8de573b5bde492dd9ca0d17f137
> Cr-Commit-Position: refs/heads/master@{#10977}

BUG=565048
Committed: https://crrev.com/bd292465ee6d8219b04f17e2ffc0790313167f01
Cr-Commit-Position: refs/heads/master@{#11015}

[Taylor Brandstetter, 2015-12-10 19:31:47]

Created Reland of Free SCTP data channels asynchronously in PeerConnection.

[Taylor Brandstetter, 2015-12-10 20:14:16]

Description was changed from

==========
Reland of Free SCTP data channels asynchronously in PeerConnection. (patchset #1
id:1 of https://codereview.webrtc.org/1513143003/ )

Reason for revert:
Relanding with slightly different solution.

Original issue's description:
> Revert of Free SCTP data channels asynchronously in PeerConnection. (patchset
#3 id:40001 of https://codereview.webrtc.org/1492383002/ )
> 
> Reason for revert:
> Breaks WebrtcTransportTest.DataStream, due to different rtc::Thread
implementation on Chromium.
> 
> Original issue's description:
> > Free SCTP data channels asynchronously in PeerConnection.
> >
> > This is needed so that the data channel isn't deleted while one of its
> > own methods is on the call stack.
> >
> > BUG=565048
> >
> > Committed: https://crrev.com/386869247f28e72a00307a1b5c92465eea343ad2
> > Cr-Commit-Position: refs/heads/master@{#10923}
> 
> TBR=pthatcher@webrtc.org
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=565048
> 
> Committed: https://crrev.com/a1f567ae9012a8de573b5bde492dd9ca0d17f137
> Cr-Commit-Position: refs/heads/master@{#10977}

TBR=pthatcher@webrtc.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=565048
==========

to

==========
Reland of Free SCTP data channels asynchronously in PeerConnection. (patchset #1
id:1 of https://codereview.webrtc.org/1513143003/ )

Original issue's description:
> Revert of Free SCTP data channels asynchronously in PeerConnection. (patchset
#3 id:40001 of https://codereview.webrtc.org/1492383002/ )
> 
> Reason for revert:
> Breaks WebrtcTransportTest.DataStream, due to different rtc::Thread
implementation on Chromium.
> 
> Original issue's description:
> > Free SCTP data channels asynchronously in PeerConnection.
> >
> > This is needed so that the data channel isn't deleted while one of its
> > own methods is on the call stack.
> >
> > BUG=565048
> >
> > Committed: https://crrev.com/386869247f28e72a00307a1b5c92465eea343ad2
> > Cr-Commit-Position: refs/heads/master@{#10923}
> 
> TBR=pthatcher@webrtc.org
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=565048
> 
> Committed: https://crrev.com/a1f567ae9012a8de573b5bde492dd9ca0d17f137
> Cr-Commit-Position: refs/heads/master@{#10977}

BUG=565048
==========

[pthatcher1, 2015-12-11 02:55:01]

lgtm

https://codereview.webrtc.org/1516943002/diff/70001/talk/app/webrtc/peerconne...
File talk/app/webrtc/peerconnection.cc (right):

https://codereview.webrtc.org/1516943002/diff/70001/talk/app/webrtc/peerconne...
talk/app/webrtc/peerconnection.cc:1918:
sctp_data_channels_to_free_.push_back(*it);
We should probably add a RTC_DCHECK(signaling_thread()->IsCurrent()) to this
method.

[Taylor Brandstetter, 2015-12-11 18:21:48]

https://codereview.webrtc.org/1516943002/diff/70001/talk/app/webrtc/peerconne...
File talk/app/webrtc/peerconnection.cc (right):

https://codereview.webrtc.org/1516943002/diff/70001/talk/app/webrtc/peerconne...
talk/app/webrtc/peerconnection.cc:1918:
sctp_data_channels_to_free_.push_back(*it);
On 2015/12/11 02:55:01, pthatcher1 wrote:
> We should probably add a RTC_DCHECK(signaling_thread()->IsCurrent()) to this
> method.

Done.

[Taylor Brandstetter, 2015-12-14 19:27:14]

The CQ bit was checked by deadbeef@webrtc.org

[Taylor Brandstetter, 2015-12-14 19:27:15]

The patchset sent to the CQ was uploaded after l-g-t-m from pthatcher@webrtc.org
Link to the patchset: https://codereview.webrtc.org/1516943002/#ps90001 (title:
"Adding RTC_DCHECK as suggested.")

[commit-bot: I haz the power, 2015-12-14 19:27:27]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1516943002/90001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1516943002/90001

[commit-bot: I haz the power, 2015-12-14 21:28:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-12-14 21:28:05]

Try jobs failed on following builders:
  android_arm64_rel on tryserver.webrtc (JOB_TIMED_OUT, no build URL)
  linux_baremetal on tryserver.webrtc (JOB_TIMED_OUT, no build URL)
  mac_baremetal on tryserver.webrtc (JOB_TIMED_OUT, no build URL)
  win_baremetal on tryserver.webrtc (JOB_TIMED_OUT, no build URL)

[Taylor Brandstetter, 2015-12-15 02:01:37]

The CQ bit was checked by deadbeef@webrtc.org

[commit-bot: I haz the power, 2015-12-15 02:01:47]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1516943002/90001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1516943002/90001

[commit-bot: I haz the power, 2015-12-15 02:15:32]

Description was changed from

==========
Reland of Free SCTP data channels asynchronously in PeerConnection. (patchset #1
id:1 of https://codereview.webrtc.org/1513143003/ )

Original issue's description:
> Revert of Free SCTP data channels asynchronously in PeerConnection. (patchset
#3 id:40001 of https://codereview.webrtc.org/1492383002/ )
> 
> Reason for revert:
> Breaks WebrtcTransportTest.DataStream, due to different rtc::Thread
implementation on Chromium.
> 
> Original issue's description:
> > Free SCTP data channels asynchronously in PeerConnection.
> >
> > This is needed so that the data channel isn't deleted while one of its
> > own methods is on the call stack.
> >
> > BUG=565048
> >
> > Committed: https://crrev.com/386869247f28e72a00307a1b5c92465eea343ad2
> > Cr-Commit-Position: refs/heads/master@{#10923}
> 
> TBR=pthatcher@webrtc.org
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=565048
> 
> Committed: https://crrev.com/a1f567ae9012a8de573b5bde492dd9ca0d17f137
> Cr-Commit-Position: refs/heads/master@{#10977}

BUG=565048
==========

to

==========
Reland of Free SCTP data channels asynchronously in PeerConnection. (patchset #1
id:1 of https://codereview.webrtc.org/1513143003/ )

Original issue's description:
> Revert of Free SCTP data channels asynchronously in PeerConnection. (patchset
#3 id:40001 of https://codereview.webrtc.org/1492383002/ )
> 
> Reason for revert:
> Breaks WebrtcTransportTest.DataStream, due to different rtc::Thread
implementation on Chromium.
> 
> Original issue's description:
> > Free SCTP data channels asynchronously in PeerConnection.
> >
> > This is needed so that the data channel isn't deleted while one of its
> > own methods is on the call stack.
> >
> > BUG=565048
> >
> > Committed: https://crrev.com/386869247f28e72a00307a1b5c92465eea343ad2
> > Cr-Commit-Position: refs/heads/master@{#10923}
> 
> TBR=pthatcher@webrtc.org
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=565048
> 
> Committed: https://crrev.com/a1f567ae9012a8de573b5bde492dd9ca0d17f137
> Cr-Commit-Position: refs/heads/master@{#10977}

BUG=565048
==========

[commit-bot: I haz the power, 2015-12-15 02:15:33]

Committed patchset #3 (id:90001)

[commit-bot: I haz the power, 2015-12-15 02:15:39]

Description was changed from

==========
Reland of Free SCTP data channels asynchronously in PeerConnection. (patchset #1
id:1 of https://codereview.webrtc.org/1513143003/ )

Original issue's description:
> Revert of Free SCTP data channels asynchronously in PeerConnection. (patchset
#3 id:40001 of https://codereview.webrtc.org/1492383002/ )
> 
> Reason for revert:
> Breaks WebrtcTransportTest.DataStream, due to different rtc::Thread
implementation on Chromium.
> 
> Original issue's description:
> > Free SCTP data channels asynchronously in PeerConnection.
> >
> > This is needed so that the data channel isn't deleted while one of its
> > own methods is on the call stack.
> >
> > BUG=565048
> >
> > Committed: https://crrev.com/386869247f28e72a00307a1b5c92465eea343ad2
> > Cr-Commit-Position: refs/heads/master@{#10923}
> 
> TBR=pthatcher@webrtc.org
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=565048
> 
> Committed: https://crrev.com/a1f567ae9012a8de573b5bde492dd9ca0d17f137
> Cr-Commit-Position: refs/heads/master@{#10977}

BUG=565048
==========

to

==========
Reland of Free SCTP data channels asynchronously in PeerConnection. (patchset #1
id:1 of https://codereview.webrtc.org/1513143003/ )

Original issue's description:
> Revert of Free SCTP data channels asynchronously in PeerConnection. (patchset
#3 id:40001 of https://codereview.webrtc.org/1492383002/ )
>
> Reason for revert:
> Breaks WebrtcTransportTest.DataStream, due to different rtc::Thread
implementation on Chromium.
>
> Original issue's description:
> > Free SCTP data channels asynchronously in PeerConnection.
> >
> > This is needed so that the data channel isn't deleted while one of its
> > own methods is on the call stack.
> >
> > BUG=565048
> >
> > Committed: https://crrev.com/386869247f28e72a00307a1b5c92465eea343ad2
> > Cr-Commit-Position: refs/heads/master@{#10923}
>
> TBR=pthatcher@webrtc.org
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=565048
>
> Committed: https://crrev.com/a1f567ae9012a8de573b5bde492dd9ca0d17f137
> Cr-Commit-Position: refs/heads/master@{#10977}

BUG=565048

Committed: https://crrev.com/bd292465ee6d8219b04f17e2ffc0790313167f01
Cr-Commit-Position: refs/heads/master@{#11015}
==========

[commit-bot: I haz the power, 2015-12-15 02:15:40]

Patchset 3 (id:??) landed as
https://crrev.com/bd292465ee6d8219b04f17e2ffc0790313167f01
Cr-Commit-Position: refs/heads/master@{#11015}