Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(163)

Side by Side Diff: webrtc/p2p/base/portinterface.h

Issue 1516613002: Only try to pair protocol matching candidates for creating connections. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc@master
Patch Set: merge Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « webrtc/p2p/base/port_unittest.cc ('k') | webrtc/p2p/base/relayport.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright 2012 The WebRTC Project Authors. All rights reserved. 2 * Copyright 2012 The WebRTC Project Authors. All rights reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
(...skipping 35 matching lines...) Expand 10 before | Expand all | Expand 10 after
46 46
47 // Methods to set/get ICE role and tiebreaker values. 47 // Methods to set/get ICE role and tiebreaker values.
48 virtual void SetIceRole(IceRole role) = 0; 48 virtual void SetIceRole(IceRole role) = 0;
49 virtual IceRole GetIceRole() const = 0; 49 virtual IceRole GetIceRole() const = 0;
50 50
51 virtual void SetIceTiebreaker(uint64_t tiebreaker) = 0; 51 virtual void SetIceTiebreaker(uint64_t tiebreaker) = 0;
52 virtual uint64_t IceTiebreaker() const = 0; 52 virtual uint64_t IceTiebreaker() const = 0;
53 53
54 virtual bool SharedSocket() const = 0; 54 virtual bool SharedSocket() const = 0;
55 55
56 virtual bool SupportsProtocol(const std::string& protocol) const = 0;
57
56 // PrepareAddress will attempt to get an address for this port that other 58 // PrepareAddress will attempt to get an address for this port that other
57 // clients can send to. It may take some time before the address is ready. 59 // clients can send to. It may take some time before the address is ready.
58 // Once it is ready, we will send SignalAddressReady. If errors are 60 // Once it is ready, we will send SignalAddressReady. If errors are
59 // preventing the port from getting an address, it may send 61 // preventing the port from getting an address, it may send
60 // SignalAddressError. 62 // SignalAddressError.
61 virtual void PrepareAddress() = 0; 63 virtual void PrepareAddress() = 0;
62 64
63 // Returns the connection to the given address or NULL if none exists. 65 // Returns the connection to the given address or NULL if none exists.
64 virtual Connection* GetConnection( 66 virtual Connection* GetConnection(
65 const rtc::SocketAddress& remote_addr) = 0; 67 const rtc::SocketAddress& remote_addr) = 0;
(...skipping 52 matching lines...) Expand 10 before | Expand all | Expand 10 after
118 120
119 virtual std::string ToString() const = 0; 121 virtual std::string ToString() const = 0;
120 122
121 protected: 123 protected:
122 PortInterface() {} 124 PortInterface() {}
123 }; 125 };
124 126
125 } // namespace cricket 127 } // namespace cricket
126 128
127 #endif // WEBRTC_P2P_BASE_PORTINTERFACE_H_ 129 #endif // WEBRTC_P2P_BASE_PORTINTERFACE_H_
OLDNEW
« no previous file with comments | « webrtc/p2p/base/port_unittest.cc ('k') | webrtc/p2p/base/relayport.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698