Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(391)

Issue 1516423004: Update WARN_UNUSED_RESULT macro to match Chromium's version. (Closed)

Created:
5 years ago by tfarina
Modified:
5 years ago
Reviewers:
tommi
CC:
webrtc-reviews_webrtc.org, interface-changes_webrtc.org, rwolff_gocast.it, yujie_mao (webrtc), tterriberry_mozilla.com, qiang.lu, niklas.enbom, peah-webrtc, dcheng, mflodman
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Update WARN_UNUSED_RESULT macro to match Chromium's version. It also matches the one in webrtc/base/common.h BUG=None R=tommi@webrtc.org Committed: https://crrev.com/66679dcc04658e5e0dc334f53e647eb9eb3107ed Cr-Commit-Position: refs/heads/master@{#10998}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M webrtc/typedefs.h View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 11 (4 generated)
tfarina
Tommi, PTAL. Daniel, fyi.
5 years ago (2015-12-12 01:30:08 UTC) #1
tommi
lgtm
5 years ago (2015-12-12 01:35:09 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1516423004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1516423004/1
5 years ago (2015-12-12 01:35:11 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_rel on tryserver.webrtc (JOB_TIMED_OUT, no build URL) mac_baremetal on ...
5 years ago (2015-12-12 03:29:19 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1516423004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1516423004/1
5 years ago (2015-12-12 13:46:25 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-12 13:47:29 UTC) #10
commit-bot: I haz the power
5 years ago (2015-12-12 13:47:29 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/66679dcc04658e5e0dc334f53e647eb9eb3107ed
Cr-Commit-Position: refs/heads/master@{#10998}

Powered by Google App Engine
This is Rietveld 408576698