Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 1516163003: Add "x"s in the end of a stripped IPv6 address string. (Closed)

Created:
5 years ago by Henrik Grunell WebRTC
Modified:
5 years ago
Reviewers:
tommi
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Add "x"s in the end of a stripped IPv6 address string. This makes it clearer that the IP address has been stripped. BUG=chromium:254329 Committed: https://crrev.com/ac921d7365e83b1e271e05a2654ef705de5c60b7 Cr-Commit-Position: refs/heads/master@{#11005}

Patch Set 1 #

Patch Set 2 : Improved to append x:x:x:x:x. Updated unit test. #

Patch Set 3 : Fixed test. #

Patch Set 4 : Fixed typo. Rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -6 lines) Patch
M webrtc/base/ipaddress.cc View 1 2 3 2 chunks +14 lines, -3 lines 0 comments Download
M webrtc/base/ipaddress_unittest.cc View 1 3 chunks +14 lines, -1 line 0 comments Download
M webrtc/base/socketaddress_unittest.cc View 1 2 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 21 (12 generated)
Henrik Grunell WebRTC
5 years ago (2015-12-11 14:26:05 UTC) #3
tommi
lgtm
5 years ago (2015-12-11 15:46:01 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1516163003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1516163003/20001
5 years ago (2015-12-11 15:46:10 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: mac_rel on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/mac_rel/builds/11510) mac_x64_rel on tryserver.webrtc (JOB_FAILED, ...
5 years ago (2015-12-11 15:53:20 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1516163003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1516163003/40001
5 years ago (2015-12-11 16:10:17 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_rel on tryserver.webrtc (JOB_TIMED_OUT, no build URL) linux_baremetal on ...
5 years ago (2015-12-11 18:10:36 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1516163003/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1516163003/60001
5 years ago (2015-12-14 08:20:56 UTC) #17
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years ago (2015-12-14 10:07:06 UTC) #19
commit-bot: I haz the power
5 years ago (2015-12-14 10:07:14 UTC) #21
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/ac921d7365e83b1e271e05a2654ef705de5c60b7
Cr-Commit-Position: refs/heads/master@{#11005}

Powered by Google App Engine
This is Rietveld 408576698