Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issue 1514573003: Add empty placeholder files for remote audio tracks. (Closed)

Created:
5 years ago by tommi
Modified:
5 years ago
Reviewers:
henrika_webrtc
CC:
webrtc-reviews_webrtc.org
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Add empty placeholder files for remote audio tracks. This is needed for Chromium so that we can roll, update libjingle.gyp and then continue. BUG=chromium:121673 Committed: https://crrev.com/434aca8d862a46d0c3b71698a264d0c71d898170 Cr-Commit-Position: refs/heads/master@{#10955}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -9 lines) Patch
A + talk/app/webrtc/remoteaudiotrack.h View 2 chunks +4 lines, -6 lines 0 comments Download
A + talk/app/webrtc/remoteaudiotrack.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M talk/libjingle.gyp View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
tommi
Hej Henrik - can you take a look? No code being introduced and the diff ...
5 years ago (2015-12-09 16:40:09 UTC) #2
henrika_webrtc
LGTM
5 years ago (2015-12-09 16:44:18 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1514573003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1514573003/1
5 years ago (2015-12-09 16:52:05 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-09 17:41:58 UTC) #6
commit-bot: I haz the power
5 years ago (2015-12-09 17:42:09 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/434aca8d862a46d0c3b71698a264d0c71d898170
Cr-Commit-Position: refs/heads/master@{#10955}

Powered by Google App Engine
This is Rietveld 408576698