Add aecdump support to AppRTCDemo

Add aecdump support to AppRTCDemo

Committed: https://crrev.com/0b0a88b918062ee50a36a8e8b5d7f0cc040046fb
Cr-Commit-Position: refs/heads/master@{#10985}

[aluebs-webrtc, 2015-12-10 23:44:18]

Description was changed from

==========
Add aecdump support to AppRTCDemoy
==========

to

==========
Add aecdump support to AppRTCDemo
==========

[aluebs-webrtc, 2015-12-10 23:47:56]

aluebs@webrtc.org changed reviewers:
+ glaznev@webrtc.org, tkchin@webrtc.org

[AlexG, 2015-12-11 00:04:07]

Please also update test at webrtc/examples/androidtests to use new
peerConnectionParameters

https://codereview.webrtc.org/1514473008/diff/1/webrtc/examples/androidapp/sr...
File webrtc/examples/androidapp/src/org/appspot/apprtc/PeerConnectionClient.java
(right):

https://codereview.webrtc.org/1514473008/diff/1/webrtc/examples/androidapp/sr...
webrtc/examples/androidapp/src/org/appspot/apprtc/PeerConnectionClient.java:495:
} catch(IOException e) {}
Print error message with exception description in catch block

https://codereview.webrtc.org/1514473008/diff/1/webrtc/examples/androidapp/sr...
webrtc/examples/androidapp/src/org/appspot/apprtc/PeerConnectionClient.java:496:
factory.startAecDump(aecDumpFileDescriptor.getFd());
Move this call to try block to avoid calling it when file can not be created

[aluebs-webrtc, 2015-12-11 03:19:09]

Addressed comments and fixed tests.

https://codereview.webrtc.org/1514473008/diff/1/webrtc/examples/androidapp/sr...
File webrtc/examples/androidapp/src/org/appspot/apprtc/PeerConnectionClient.java
(right):

https://codereview.webrtc.org/1514473008/diff/1/webrtc/examples/androidapp/sr...
webrtc/examples/androidapp/src/org/appspot/apprtc/PeerConnectionClient.java:495:
} catch(IOException e) {}
On 2015/12/11 00:04:07, AlexG wrote:
> Print error message with exception description in catch block

Great point! I forgot to add this after I decided my local hack was worth
committing :)
Done.

https://codereview.webrtc.org/1514473008/diff/1/webrtc/examples/androidapp/sr...
webrtc/examples/androidapp/src/org/appspot/apprtc/PeerConnectionClient.java:496:
factory.startAecDump(aecDumpFileDescriptor.getFd());
On 2015/12/11 00:04:07, AlexG wrote:
> Move this call to try block to avoid calling it when file can not be created

Of course! Done.

[AlexG, 2015-12-11 04:27:30]

lgtm

[aluebs-webrtc, 2015-12-11 04:37:50]

The CQ bit was checked by aluebs@webrtc.org

[commit-bot: I haz the power, 2015-12-11 04:38:02]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1514473008/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1514473008/20001

[commit-bot: I haz the power, 2015-12-11 07:28:46]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-12-11 07:28:56]

Description was changed from

==========
Add aecdump support to AppRTCDemo
==========

to

==========
Add aecdump support to AppRTCDemo

Committed: https://crrev.com/0b0a88b918062ee50a36a8e8b5d7f0cc040046fb
Cr-Commit-Position: refs/heads/master@{#10985}
==========

[commit-bot: I haz the power, 2015-12-11 07:28:57]

Patchset 2 (id:??) landed as
https://crrev.com/0b0a88b918062ee50a36a8e8b5d7f0cc040046fb
Cr-Commit-Position: refs/heads/master@{#10985}