PRESUBMIT: Split NATIVE_API_DIRS into two lists.

PRESUBMIT.py

 # Copyright (c) 2012 The WebRTC project authors. All Rights Reserved.
 #
 # Use of this source code is governed by a BSD-style license
 # that can be found in the LICENSE file in the root of the source
 # tree. An additional intellectual property rights grant can be found
 # in the file PATENTS.  All contributing project authors may
 # be found in the AUTHORS file in the root of the source tree.
 
 import json
 import os
@@ skipping 11 matching lines @@
   'webrtc/video',
 ]
 
 # List of directories of "supported" native APIs. That means changes to headers
 # will be done in a compatible way following this scheme:
 # 1. Non-breaking changes are made.
 # 2. The old APIs as marked as deprecated (with comments).
 # 3. Deprecation is announced to discuss-webrtc@googlegroups.com and
 #    webrtc-users@google.com (internal list).
 # 4. (later) The deprecated APIs are removed.
-# Directories marked as DEPRECATED should not be used. They're only present in
-# the list to support legacy downstream code.
 NATIVE_API_DIRS = (
   'talk/app/webrtc',

[the sun, 2015/12/10 10:56:57]

Note that until there is an include/ dir under talk/app/webrtc it would probably
be best to keep in under LEGACY as well.

   'webrtc',
-  'webrtc/base',  # DEPRECATED.
-  'webrtc/common_audio/include',  # DEPRECATED.
   'webrtc/modules/audio_coding/include',

[the sun, 2015/12/10 10:02:20]

Move to LEGACY:
webrtc/modules/audio_coding/include
webrtc/modules/audio_processing/include
webrtc/voice_engine/include

Also, I'd like to move:
webrtc/modules/bitrate_controller/include
webrtc/modules/remote_bitrate_estimator/include
webrtc/modules/rtp_rtcp/include
webrtc/modules/utility/include
as well, but Stefan may have thoughts on that?

[stefan-webrtc, 2015/12/10 10:14:32]

No, I'm OK with that. We don't want new projects to start using these modules
directly.

[pbos-webrtc, 2015/12/10 10:20:01]

I think all of video_coding should also go under legacy.

[the sun, 2015/12/10 10:56:57]

Ah, I thought that was required to feed codec instances to the video streams.

Would that mean webrtc/modules/include can go under legacy too?

-  'webrtc/modules/audio_conference_mixer/include',  # DEPRECATED.
   'webrtc/modules/audio_device/include',
   'webrtc/modules/audio_processing/include',
   'webrtc/modules/bitrate_controller/include',
   'webrtc/modules/include',
   'webrtc/modules/remote_bitrate_estimator/include',
   'webrtc/modules/rtp_rtcp/include',
-  'webrtc/modules/rtp_rtcp/source',  # DEPRECATED.
   'webrtc/modules/utility/include',
   'webrtc/modules/video_coding/codecs/h264/include',
   'webrtc/modules/video_coding/codecs/i420/include',
   'webrtc/modules/video_coding/codecs/vp8/include',
   'webrtc/modules/video_coding/codecs/vp9/include',
   'webrtc/modules/video_coding/include',
-  'webrtc/system_wrappers/include',  # DEPRECATED.
   'webrtc/voice_engine/include',
 )
+# These directories should not be used but are maintained only to avoid breaking
+# some legacy downstream code.
+LEGACY_API_DIRS = (
+  'webrtc/base',
+  'webrtc/common_audio/include',
+  'webrtc/modules/audio_conference_mixer/include',
+  'webrtc/modules/rtp_rtcp/source',
+  'webrtc/system_wrappers/include',
+)
+API_DIRS = NATIVE_API_DIRS[:] + LEGACY_API_DIRS[:]
 
 
 def _VerifyNativeApiHeadersListIsValid(input_api, output_api):
   """Ensures the list of native API header directories is up to date."""
   non_existing_paths = []
   native_api_full_paths = [
       input_api.os_path.join(input_api.PresubmitLocalPath(),
-                             *path.split('/')) for path in NATIVE_API_DIRS]
+                             *path.split('/')) for path in API_DIRS]
   for path in native_api_full_paths:
     if not os.path.isdir(path):
       non_existing_paths.append(path)
   if non_existing_paths:
     return [output_api.PresubmitError(
         'Directories to native API headers have changed which has made the '
         'list in PRESUBMIT.py outdated.\nPlease update it to the current '
         'location of our native APIs.',
         non_existing_paths)]
   return []
 
 
 def _CheckNativeApiHeaderChanges(input_api, output_api):
   """Checks to remind proper changing of native APIs."""
   files = []
   for f in input_api.AffectedSourceFiles(input_api.FilterSourceFile):
     if f.LocalPath().endswith('.h'):
-      for path in NATIVE_API_DIRS:
+      for path in API_DIRS:
         if os.path.dirname(f.LocalPath()) == path:
           files.append(f)
 
   if files:
     return [output_api.PresubmitNotifyResult(
         'You seem to be changing native API header files. Please make sure '
         'you:\n'
         '  1. Make compatible changes that don\'t break existing clients.\n'
         '  2. Mark the old APIs as deprecated.\n'
         '  3. Create a timeline and plan for when the deprecated method will '
@@ skipping 364 matching lines @@
     for builder in masters[master]:
       if 'presubmit' in builder:
         # Do not trigger presubmit builders, since they're likely to fail
         # (e.g. OWNERS checks before finished code review), and we're running
         # local presubmit anyway.
         pass
       else:
         try_config[master][builder] = ['defaulttests']
 
   return try_config