Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Issue 1513483005: Typo fix: Enable a bunch of tests that were accidentally disabled (Closed)

Created:
5 years ago by kwiberg-webrtc
Modified:
5 years ago
Reviewers:
hlundin-webrtc
CC:
webrtc-reviews_webrtc.org, kwiberg-webrtc, tlegrand-webrtc, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, peah-webrtc, minyue-webrtc
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Typo fix: Enable a bunch of tests that were accidentally disabled They were meant to be run if we have either iSAC float or fix, but the typo made them run for just float. BUG=webrtc:4198, webrtc:4199 Committed: https://crrev.com/866df6602c7ceb7196c3d32e1dd2e3844592224b Cr-Commit-Position: refs/heads/master@{#10969}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M webrtc/modules/audio_coding/acm2/audio_coding_module_unittest_oldapi.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_coding/neteq/neteq_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (5 generated)
kwiberg-webrtc
I'm pretty sure I made both the original typo and the copy...
5 years ago (2015-12-09 13:54:24 UTC) #3
hlundin-webrtc
lgtm
5 years ago (2015-12-10 12:13:47 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1513483005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1513483005/1
5 years ago (2015-12-10 12:14:49 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-10 12:20:06 UTC) #8
commit-bot: I haz the power
5 years ago (2015-12-10 12:20:12 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/866df6602c7ceb7196c3d32e1dd2e3844592224b
Cr-Commit-Position: refs/heads/master@{#10969}

Powered by Google App Engine
This is Rietveld 408576698