Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(62)

Issue 1513303003: [rtp_rtcp] fixed lint errors in rtp_rtcp module that are not fixed in other CLs (Closed)

Created:
5 years ago by danilchap
Modified:
5 years ago
Reviewers:
mflodman
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, zhuangzesen_agora.io, stefan-webrtc, mflodman, åsapersson
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

[rtp_rtcp] fixed lint errors in rtp_rtcp module that are not fixed in other CLs BUG=webrtc:5277 R=mflodman Committed: https://crrev.com/6db6cdc604f9a866991ecf8454eb7f7aa69918ea Cr-Commit-Position: refs/heads/master@{#11025}

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+67 lines, -56 lines) Patch
M webrtc/modules/rtp_rtcp/mocks/mock_rtp_rtcp.h View 4 chunks +8 lines, -6 lines 0 comments Download
A webrtc/modules/rtp_rtcp/source/CPPLINT.cfg View 1 chunk +8 lines, -0 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/fec_receiver_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/rtp_rtcp/source/nack_rtx_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtcp_format_remb_unittest.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtcp_receiver.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtcp_receiver.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtcp_sender.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_header_extension.h View 1 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_packet_history.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_receiver_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_receiver_impl.cc View 5 chunks +5 lines, -5 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_receiver_strategy.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_rtcp_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_rtcp_impl.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_rtcp_impl_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_sender.cc View 1 2 5 chunks +6 lines, -6 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_sender_audio.h View 2 chunks +2 lines, -2 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_sender_audio.cc View 3 chunks +10 lines, -10 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_sender_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_sender_video.h View 1 chunk +3 lines, -3 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_sender_video.cc View 1 chunk +6 lines, -6 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
danilchap
5 years ago (2015-12-11 09:23:54 UTC) #1
mflodman
LGTM
5 years ago (2015-12-14 13:04:43 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1513303003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1513303003/40001
5 years ago (2015-12-15 10:52:22 UTC) #5
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years ago (2015-12-15 10:54:51 UTC) #6
commit-bot: I haz the power
5 years ago (2015-12-15 10:54:55 UTC) #8
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/6db6cdc604f9a866991ecf8454eb7f7aa69918ea
Cr-Commit-Position: refs/heads/master@{#11025}

Powered by Google App Engine
This is Rietveld 408576698