Reduce the runtime of some ACM tests in modules_tests

Reduce the runtime of some ACM tests in modules_tests

By reducing the length of the audio input, the total runtime of
$ out/Debug/modules_tests --gtest_filter=AudioCodingModuleTest.*
is reduced by more than 10x, when run single-threaded.

The PCMFile helper class is extended with a FastForward method (to
skip initial silence in the test files) and a limiter on how much to
read.

BUG=webrtc:2463
R=ivoc@webrtc.org

Committed: https://crrev.com/4d68208a2089bfb7c9bf87f06722033a9e82a2a3
Cr-Commit-Position: refs/heads/master@{#10973}

[hlundin-webrtc, 2015-12-10 10:32:50]

henrik.lundin@webrtc.org changed reviewers:
+ ivoc@webrtc.org

[hlundin-webrtc, 2015-12-10 10:32:51]

Ivo,

Please, take a look.

[ivoc, 2015-12-10 12:23:57]

lgtm with some small nits.

https://codereview.webrtc.org/1513223002/diff/1/webrtc/modules/audio_coding/t...
File webrtc/modules/audio_coding/test/EncodeDecodeTest.cc (right):

https://codereview.webrtc.org/1513223002/diff/1/webrtc/modules/audio_coding/t...
webrtc/modules/audio_coding/test/EncodeDecodeTest.cc:67: static const int
kTestLengthMs = 500;
Not sure what the point of static is here.

https://codereview.webrtc.org/1513223002/diff/1/webrtc/modules/audio_coding/t...
File webrtc/modules/audio_coding/test/PCMFile.cc (right):

https://codereview.webrtc.org/1513223002/diff/1/webrtc/modules/audio_coding/t...
webrtc/modules/audio_coding/test/PCMFile.cc:33:
num_10ms_blocks_to_read_(rtc::Optional<int>()) {
Can this be initialized in the .h file as well? Or is there a reason not to do
that?

https://codereview.webrtc.org/1513223002/diff/1/webrtc/modules/audio_coding/t...
File webrtc/modules/audio_coding/test/TestAllCodecs.cc (right):

https://codereview.webrtc.org/1513223002/diff/1/webrtc/modules/audio_coding/t...
webrtc/modules/audio_coding/test/TestAllCodecs.cc:429:
infile_a_.SetNum10MsBlocksToRead(test_length_blocks);
You could consider hardcoding the number of blocks here as below, and explain in
a comment.

[hlundin-webrtc, 2015-12-10 12:47:04]

Taking care of review comments

[hlundin-webrtc, 2015-12-10 12:48:41]

Taking care of review comments

[hlundin-webrtc, 2015-12-10 12:48:54]

Patchset #2 (id:20001) has been deleted

[hlundin-webrtc, 2015-12-10 12:49:59]

https://codereview.webrtc.org/1513223002/diff/1/webrtc/modules/audio_coding/t...
File webrtc/modules/audio_coding/test/EncodeDecodeTest.cc (right):

https://codereview.webrtc.org/1513223002/diff/1/webrtc/modules/audio_coding/t...
webrtc/modules/audio_coding/test/EncodeDecodeTest.cc:67: static const int
kTestLengthMs = 500;
On 2015/12/10 12:23:57, ivoc wrote:
> Not sure what the point of static is here.

Gone.

https://codereview.webrtc.org/1513223002/diff/1/webrtc/modules/audio_coding/t...
File webrtc/modules/audio_coding/test/PCMFile.cc (right):

https://codereview.webrtc.org/1513223002/diff/1/webrtc/modules/audio_coding/t...
webrtc/modules/audio_coding/test/PCMFile.cc:33:
num_10ms_blocks_to_read_(rtc::Optional<int>()) {
On 2015/12/10 12:23:57, ivoc wrote:
> Can this be initialized in the .h file as well? Or is there a reason not to do
> that?

In fact, it's not needed at all. The default ctor for rtc::Optional will give an
unset value.

https://codereview.webrtc.org/1513223002/diff/1/webrtc/modules/audio_coding/t...
File webrtc/modules/audio_coding/test/TestAllCodecs.cc (right):

https://codereview.webrtc.org/1513223002/diff/1/webrtc/modules/audio_coding/t...
webrtc/modules/audio_coding/test/TestAllCodecs.cc:429:
infile_a_.SetNum10MsBlocksToRead(test_length_blocks);
On 2015/12/10 12:23:57, ivoc wrote:
> You could consider hardcoding the number of blocks here as below, and explain
in
> a comment.

Done.

[hlundin-webrtc, 2015-12-10 12:50:09]

The CQ bit was checked by henrik.lundin@webrtc.org

[hlundin-webrtc, 2015-12-10 12:50:10]

The patchset sent to the CQ was uploaded after l-g-t-m from ivoc@webrtc.org
Link to the patchset: https://codereview.webrtc.org/1513223002/#ps40001 (title:
"Taking care of review comments")

[commit-bot: I haz the power, 2015-12-10 12:50:19]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1513223002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1513223002/40001

[commit-bot: I haz the power, 2015-12-10 13:13:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-12-10 13:13:13]

Try jobs failed on following builders:
  win_x64_rel on tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/win_x64_rel/builds/11275)

[hlundin-webrtc, 2015-12-10 13:47:57]

Fixing win64 build

[hlundin-webrtc, 2015-12-10 15:24:55]

Description was changed from

==========
Reduce the runtime of some ACM tests in modules_tests

By reducing the length of the audio input, the total runtime of
$ out/Debug/modules_tests --gtest_filter=AudioCodingModuleTest.*
is reduced by more than 10x, when run single-threaded.

The PCMFile helper class is extended with a FastForward method (to
skip initial silence in the test files) and a limiter on how much to
read.

BUG=webrtc:2463
==========

to

==========
Reduce the runtime of some ACM tests in modules_tests

By reducing the length of the audio input, the total runtime of
$ out/Debug/modules_tests --gtest_filter=AudioCodingModuleTest.*
is reduced by more than 10x, when run single-threaded.

The PCMFile helper class is extended with a FastForward method (to
skip initial silence in the test files) and a limiter on how much to
read.

BUG=webrtc:2463
R=ivoc@webrtc.org

Committed:
https://chromium.googlesource.com/external/webrtc/+/4d68208a2089bfb7c9bf87f06...
==========

[hlundin-webrtc, 2015-12-10 15:24:56]

Committed patchset #3 (id:60001) manually as
4d68208a2089bfb7c9bf87f06722033a9e82a2a3 (presubmit successful).

[commit-bot: I haz the power, 2015-12-10 15:24:58]

Description was changed from

==========
Reduce the runtime of some ACM tests in modules_tests

By reducing the length of the audio input, the total runtime of
$ out/Debug/modules_tests --gtest_filter=AudioCodingModuleTest.*
is reduced by more than 10x, when run single-threaded.

The PCMFile helper class is extended with a FastForward method (to
skip initial silence in the test files) and a limiter on how much to
read.

BUG=webrtc:2463
R=ivoc@webrtc.org

Committed:
https://chromium.googlesource.com/external/webrtc/+/4d68208a2089bfb7c9bf87f06...
==========

to

==========
Reduce the runtime of some ACM tests in modules_tests

By reducing the length of the audio input, the total runtime of
$ out/Debug/modules_tests --gtest_filter=AudioCodingModuleTest.*
is reduced by more than 10x, when run single-threaded.

The PCMFile helper class is extended with a FastForward method (to
skip initial silence in the test files) and a limiter on how much to
read.

BUG=webrtc:2463
R=ivoc@webrtc.org

Committed: https://crrev.com/4d68208a2089bfb7c9bf87f06722033a9e82a2a3
Cr-Commit-Position: refs/heads/master@{#10973}
==========

[commit-bot: I haz the power, 2015-12-10 15:24:59]

Patchset 3 (id:??) landed as
https://crrev.com/4d68208a2089bfb7c9bf87f06722033a9e82a2a3
Cr-Commit-Position: refs/heads/master@{#10973}