Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(196)

Issue 1513143003: Revert of Free SCTP data channels asynchronously in PeerConnection. (Closed)

Created:
5 years ago by Taylor Brandstetter
Modified:
5 years ago
Reviewers:
pthatcher1
CC:
webrtc-reviews_webrtc.org
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of Free SCTP data channels asynchronously in PeerConnection. (patchset #3 id:40001 of https://codereview.webrtc.org/1492383002/ ) Reason for revert: Breaks WebrtcTransportTest.DataStream, due to different rtc::Thread implementation on Chromium. Original issue's description: > Free SCTP data channels asynchronously in PeerConnection. > > This is needed so that the data channel isn't deleted while one of its > own methods is on the call stack. > > BUG=565048 > > Committed: https://crrev.com/386869247f28e72a00307a1b5c92465eea343ad2 > Cr-Commit-Position: refs/heads/master@{#10923} TBR=pthatcher@webrtc.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=565048 Committed: https://crrev.com/a1f567ae9012a8de573b5bde492dd9ca0d17f137 Cr-Commit-Position: refs/heads/master@{#10977}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -39 lines) Patch
M talk/app/webrtc/peerconnection.cc View 4 chunks +0 lines, -12 lines 0 comments Download
M talk/app/webrtc/peerconnectionendtoend_unittest.cc View 1 chunk +0 lines, -27 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Taylor Brandstetter
Created Revert of Free SCTP data channels asynchronously in PeerConnection.
5 years ago (2015-12-10 19:17:24 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1513143003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1513143003/1
5 years ago (2015-12-10 19:17:33 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-10 19:17:45 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/a1f567ae9012a8de573b5bde492dd9ca0d17f137 Cr-Commit-Position: refs/heads/master@{#10977}
5 years ago (2015-12-10 19:17:52 UTC) #5
Taylor Brandstetter
5 years ago (2015-12-10 19:31:47 UTC) #6
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.webrtc.org/1516943002/ by deadbeef@webrtc.org.

The reason for reverting is: Relanding with slightly different solution..

Powered by Google App Engine
This is Rietveld 408576698