Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(130)

Issue 1512853007: Remove cricket::VideoEncoderConfig. (Closed)

Created:
5 years ago by pbos-webrtc
Modified:
5 years ago
Reviewers:
noahric, pthatcher1
CC:
webrtc-reviews_webrtc.org
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : remove stale function #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -609 lines) Patch
M talk/app/webrtc/webrtcsession.cc View 1 chunk +0 lines, -10 lines 0 comments Download
M talk/media/base/codec.h View 1 chunk +0 lines, -44 lines 0 comments Download
M talk/media/base/codec_unittest.cc View 2 chunks +0 lines, -49 lines 0 comments Download
M talk/media/base/fakemediaengine.h View 3 chunks +0 lines, -11 lines 0 comments Download
M talk/media/base/mediaengine.h View 2 chunks +0 lines, -9 lines 0 comments Download
M talk/media/base/videoengine_unittest.h View 1 chunk +0 lines, -321 lines 0 comments Download
M talk/media/webrtc/webrtcvideoengine2.h View 2 chunks +0 lines, -5 lines 0 comments Download
M talk/media/webrtc/webrtcvideoengine2.cc View 1 3 chunks +0 lines, -77 lines 0 comments Download
M talk/media/webrtc/webrtcvideoengine2_unittest.cc View 2 chunks +0 lines, -31 lines 0 comments Download
M talk/session/media/channelmanager.h View 2 chunks +0 lines, -2 lines 0 comments Download
M talk/session/media/channelmanager.cc View 2 chunks +0 lines, -18 lines 0 comments Download
M talk/session/media/channelmanager_unittest.cc View 1 chunk +0 lines, -32 lines 0 comments Download

Messages

Total messages: 15 (6 generated)
pbos-webrtc
remove stale function
5 years ago (2015-12-10 11:08:38 UTC) #1
pbos-webrtc
PTAL, resolution constraints that we do wire up should be done through WebRtcVideoEncoderFactory::VideoCodec (that has ...
5 years ago (2015-12-10 11:11:17 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1512853007/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1512853007/20001
5 years ago (2015-12-10 11:12:30 UTC) #4
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: mac_baremetal on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/mac_baremetal/builds/7832)
5 years ago (2015-12-10 13:21:57 UTC) #6
pbos-webrtc
noahric@ Are you guys fine with removing SetDefaultVideoEncoderConfig calls downstream. I want this path to ...
5 years ago (2015-12-11 16:58:22 UTC) #9
pthatcher1
lgtm
5 years ago (2015-12-11 17:39:48 UTC) #10
noahric
Ell Gee Tee Em (LGTM)
5 years ago (2015-12-11 17:40:15 UTC) #11
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/822bdf978435b8eba9343ea96e9a9bc54b9c7df0 Cr-Commit-Position: refs/heads/master@{#10991}
5 years ago (2015-12-11 18:54:50 UTC) #14
pbos-webrtc
5 years ago (2015-12-11 18:54:52 UTC) #15
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
822bdf978435b8eba9343ea96e9a9bc54b9c7df0 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698