Nuke TickTime::UseFakeClock.

Nuke TickTime::UseFakeClock.

Removes the global simulated time that affects (or breaks) following
tests in the same binary and replaces it with SimulatedClock.

BUG=webrtc:5318
R=mflodman@webrtc.org

Committed: https://crrev.com/d3c944755ec546f46d5bdd84bff359fe6c4639e9
Cr-Commit-Position: refs/heads/master@{#10947}

[pbos-webrtc, 2015-12-09 09:23:08]

PTAL

[pbos-webrtc, 2015-12-09 09:23:13]

The CQ bit was checked by pbos@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2015-12-09 09:23:23]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1512853002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1512853002/1

[pbos-webrtc, 2015-12-09 09:23:39]

cl format

[pbos-webrtc, 2015-12-09 09:39:22]

Description was changed from

==========
Nuke TickTime::UseFakeClock.

Removes the global simulated time that pollutes following tests in the
same binary and replaces it with SimulatedClock.

BUG=webrtc:5318
R=mflodman@webrtc.org
==========

to

==========
Nuke TickTime::UseFakeClock.

Removes the global simulated time that affects (or breaks) following
tests in the same binary and replaces it with SimulatedClock.

BUG=webrtc:5318
R=mflodman@webrtc.org
==========

[mflodman, 2015-12-09 10:11:26]

A few comments, LGTM with these addressed.

https://codereview.webrtc.org/1512853002/diff/20001/webrtc/call/congestion_co...
File webrtc/call/congestion_controller.cc (right):

https://codereview.webrtc.org/1512853002/diff/20001/webrtc/call/congestion_co...
webrtc/call/congestion_controller.cc:150: : clock_(Clock::GetRealTimeClock()),
We might as well skip this member, inject an instance here and not have a
pointer in this class, it;s not used anywhere but in the constructor.

https://codereview.webrtc.org/1512853002/diff/20001/webrtc/call/congestion_co...
File webrtc/call/congestion_controller.h (right):

https://codereview.webrtc.org/1512853002/diff/20001/webrtc/call/congestion_co...
webrtc/call/congestion_controller.h:20: #include
"webrtc/system_wrappers/include/clock.h"
Forward declare and move to cc file.

https://codereview.webrtc.org/1512853002/diff/20001/webrtc/test/fake_network_...
File webrtc/test/fake_network_pipe.h (right):

https://codereview.webrtc.org/1512853002/diff/20001/webrtc/test/fake_network_...
webrtc/test/fake_network_pipe.h:19: #include
"webrtc/system_wrappers/include/clock.h"
Forward declare and move to cc-file.

[pbos-webrtc, 2015-12-09 10:19:04]

https://codereview.webrtc.org/1512853002/diff/20001/webrtc/call/congestion_co...
File webrtc/call/congestion_controller.cc (right):

https://codereview.webrtc.org/1512853002/diff/20001/webrtc/call/congestion_co...
webrtc/call/congestion_controller.cc:150: : clock_(Clock::GetRealTimeClock()),
On 2015/12/09 10:11:25, mflodman wrote:
> We might as well skip this member, inject an instance here and not have a
> pointer in this class, it;s not used anywhere but in the constructor.

Done.

https://codereview.webrtc.org/1512853002/diff/20001/webrtc/call/congestion_co...
File webrtc/call/congestion_controller.h (right):

https://codereview.webrtc.org/1512853002/diff/20001/webrtc/call/congestion_co...
webrtc/call/congestion_controller.h:20: #include
"webrtc/system_wrappers/include/clock.h"
On 2015/12/09 10:11:25, mflodman wrote:
> Forward declare and move to cc file.

Removed.

https://codereview.webrtc.org/1512853002/diff/20001/webrtc/test/fake_network_...
File webrtc/test/fake_network_pipe.h (right):

https://codereview.webrtc.org/1512853002/diff/20001/webrtc/test/fake_network_...
webrtc/test/fake_network_pipe.h:19: #include
"webrtc/system_wrappers/include/clock.h"
On 2015/12/09 10:11:25, mflodman wrote:
> Forward declare and move to cc-file.

Done.

[pbos-webrtc, 2015-12-09 10:19:19]

feedback

[pbos-webrtc, 2015-12-09 10:21:14]

Description was changed from

==========
Nuke TickTime::UseFakeClock.

Removes the global simulated time that affects (or breaks) following
tests in the same binary and replaces it with SimulatedClock.

BUG=webrtc:5318
R=mflodman@webrtc.org
==========

to

==========
Nuke TickTime::UseFakeClock.

Removes the global simulated time that affects (or breaks) following
tests in the same binary and replaces it with SimulatedClock.

BUG=webrtc:5318
R=mflodman@webrtc.org

Committed:
https://chromium.googlesource.com/external/webrtc/+/d3c944755ec546f46d5bdd84b...
==========

[pbos-webrtc, 2015-12-09 10:21:15]

Committed patchset #3 (id:40001) manually as
d3c944755ec546f46d5bdd84bff359fe6c4639e9 (presubmit successful).

[commit-bot: I haz the power, 2015-12-09 10:21:19]

Description was changed from

==========
Nuke TickTime::UseFakeClock.

Removes the global simulated time that affects (or breaks) following
tests in the same binary and replaces it with SimulatedClock.

BUG=webrtc:5318
R=mflodman@webrtc.org

Committed:
https://chromium.googlesource.com/external/webrtc/+/d3c944755ec546f46d5bdd84b...
==========

to

==========
Nuke TickTime::UseFakeClock.

Removes the global simulated time that affects (or breaks) following
tests in the same binary and replaces it with SimulatedClock.

BUG=webrtc:5318
R=mflodman@webrtc.org

Committed: https://crrev.com/d3c944755ec546f46d5bdd84bff359fe6c4639e9
Cr-Commit-Position: refs/heads/master@{#10947}
==========

[commit-bot: I haz the power, 2015-12-09 10:21:20]

Patchset 3 (id:??) landed as
https://crrev.com/d3c944755ec546f46d5bdd84bff359fe6c4639e9
Cr-Commit-Position: refs/heads/master@{#10947}