Special-case android-arm64 in codec bitexactness tests

Special-case android-arm64 in codec bitexactness tests

We already had a special case for android, but it only worked for arm32.

BUG=webrtc:4198, webrtc:4199
Committed: https://crrev.com/5b659c0d10f42e45e5f73daacce6975a75d9029d
Cr-Commit-Position: refs/heads/master@{#10989}

[kwiberg-webrtc, 2015-12-10 20:26:55]

Patchset #1 (id:1) has been deleted

[kwiberg-webrtc, 2015-12-10 20:27:17]

Patchset #1 (id:20001) has been deleted

[kwiberg-webrtc, 2015-12-10 20:27:37]

Patchset #1 (id:40001) has been deleted

[kwiberg-webrtc, 2015-12-10 20:27:51]

Patchset #1 (id:60001) has been deleted

[kwiberg-webrtc, 2015-12-10 20:30:35]

Description was changed from

==========
debug

BUG=webrtc:4198, webrtc:4199
==========

to

==========
Special-case android-arm64 in codec bitexactness tests

We already had a special case for android, but it only worked for arm32.

BUG=webrtc:4198, webrtc:4199
==========

[kwiberg-webrtc, 2015-12-10 20:30:36]

kwiberg@webrtc.org changed reviewers:
+ henrik.lundin@webrtc.org

[kwiberg-webrtc, 2015-12-10 20:32:04]

PTAL

Note that I've moved the "other" case so that it's the first argument instead of
the last; I found it more intuitive to have the default case first.

[hlundin-webrtc, 2015-12-11 08:36:56]

LGTM

https://codereview.webrtc.org/1512833003/diff/80001/webrtc/modules/audio_codi...
File webrtc/modules/audio_coding/acm2/audio_coding_module_unittest_oldapi.cc
(right):

https://codereview.webrtc.org/1512833003/diff/80001/webrtc/modules/audio_codi...
webrtc/modules/audio_coding/acm2/audio_coding_module_unittest_oldapi.cc:857:
#elif defined(WEBRTC_ANDROID) && defined(WEBRTC_ARCH_ARM)
So, WEBRTC_ARCH_ARM means explicitly not ARM64? Otherwise, I would feel safer
changing the order of the ARM32 and ARM64 #elifs. Up to you.

https://codereview.webrtc.org/1512833003/diff/80001/webrtc/modules/audio_codi...
webrtc/modules/audio_coding/acm2/audio_coding_module_unittest_oldapi.cc:1238:
"2b3c387d06f00b7b7aad4c9be56fb83d", "", ""),
Nit: add the "android_armXX_audio" and similar strings here too, as below.

[kwiberg-webrtc, 2015-12-11 13:39:34]

https://codereview.webrtc.org/1512833003/diff/80001/webrtc/modules/audio_codi...
File webrtc/modules/audio_coding/acm2/audio_coding_module_unittest_oldapi.cc
(right):

https://codereview.webrtc.org/1512833003/diff/80001/webrtc/modules/audio_codi...
webrtc/modules/audio_coding/acm2/audio_coding_module_unittest_oldapi.cc:857:
#elif defined(WEBRTC_ANDROID) && defined(WEBRTC_ARCH_ARM)
On 2015/12/11 08:36:56, hlundin-webrtc wrote:
> So, WEBRTC_ARCH_ARM means explicitly not ARM64? Otherwise, I would feel safer
> changing the order of the ARM32 and ARM64 #elifs. Up to you.

Yes, WEBRTC_ARCH_ARM should really be called WEBRTC_ARCH_ARM32, because that's
what it means. But historical reasons.

https://codereview.webrtc.org/1512833003/diff/80001/webrtc/modules/audio_codi...
webrtc/modules/audio_coding/acm2/audio_coding_module_unittest_oldapi.cc:1238:
"2b3c387d06f00b7b7aad4c9be56fb83d", "", ""),
On 2015/12/11 08:36:56, hlundin-webrtc wrote:
> Nit: add the "android_armXX_audio" and similar strings here too, as below.

Done.

[kwiberg-webrtc, 2015-12-11 13:39:40]

The CQ bit was checked by kwiberg@webrtc.org

[kwiberg-webrtc, 2015-12-11 13:39:41]

The patchset sent to the CQ was uploaded after l-g-t-m from
henrik.lundin@webrtc.org
Link to the patchset: https://codereview.webrtc.org/1512833003/#ps100001 (title:
"review nit")

[commit-bot: I haz the power, 2015-12-11 13:39:50]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1512833003/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1512833003/100001

[commit-bot: I haz the power, 2015-12-11 15:34:02]

Description was changed from

==========
Special-case android-arm64 in codec bitexactness tests

We already had a special case for android, but it only worked for arm32.

BUG=webrtc:4198, webrtc:4199
==========

to

==========
Special-case android-arm64 in codec bitexactness tests

We already had a special case for android, but it only worked for arm32.

BUG=webrtc:4198, webrtc:4199
==========

[commit-bot: I haz the power, 2015-12-11 15:34:03]

Committed patchset #2 (id:100001)

[commit-bot: I haz the power, 2015-12-11 15:34:11]

Description was changed from

==========
Special-case android-arm64 in codec bitexactness tests

We already had a special case for android, but it only worked for arm32.

BUG=webrtc:4198, webrtc:4199
==========

to

==========
Special-case android-arm64 in codec bitexactness tests

We already had a special case for android, but it only worked for arm32.

BUG=webrtc:4198, webrtc:4199

Committed: https://crrev.com/5b659c0d10f42e45e5f73daacce6975a75d9029d
Cr-Commit-Position: refs/heads/master@{#10989}
==========

[commit-bot: I haz the power, 2015-12-11 15:34:11]

Patchset 2 (id:??) landed as
https://crrev.com/5b659c0d10f42e45e5f73daacce6975a75d9029d
Cr-Commit-Position: refs/heads/master@{#10989}