Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issue 1512493002: [rtp_rtcp] lint whitespace warning removed from most source/ files (Closed)

Created:
5 years ago by danilchap
Modified:
5 years ago
Reviewers:
pbos-webrtc, mflodman
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, zhuangzesen_agora.io, stefan-webrtc, mflodman
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

lint whitespace warning removed from most rtp_rtcp/source/ files rtcp_utility, rtp_utility, tmmbr_help, rtcp_receiver, rtcp_receiver_help are explicetly excluded from the cleanup becaues there are short plans (or cls) to do a deeper cleaning there. BUG=webrtc:5277 R=pbos@webrtc.org, mflodman@webrtc.org Committed: https://crrev.com/162abd3562d7b08ab36569800d757b52739b9249 Cr-Commit-Position: refs/heads/master@{#10966}

Patch Set 1 #

Patch Set 2 : readability fixes added #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+974 lines, -1012 lines) Patch
M webrtc/modules/rtp_rtcp/source/dtmf_queue.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/forward_error_correction.cc View 15 chunks +41 lines, -29 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/forward_error_correction_internal.cc View 1 12 chunks +61 lines, -43 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/nack_rtx_unittest.cc View 9 chunks +14 lines, -21 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtcp_format_remb_unittest.cc View 3 chunks +4 lines, -8 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtcp_packet.h View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtcp_sender.h View 1 chunk +226 lines, -225 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtcp_sender.cc View 6 chunks +49 lines, -54 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_header_extension.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_payload_registry_unittest.cc View 10 chunks +57 lines, -56 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_receiver_audio.h View 2 chunks +6 lines, -10 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_rtcp_config.h View 1 chunk +20 lines, -19 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_sender.h View 1 2 chunks +5 lines, -5 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_sender_audio.h View 1 chunk +85 lines, -86 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_sender_audio.cc View 7 chunks +202 lines, -228 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_sender_unittest.cc View 1 30 chunks +105 lines, -109 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_sender_video.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/rtp_rtcp/source/ssrc_database.h View 1 chunk +21 lines, -22 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/ssrc_database.cc View 1 chunk +50 lines, -68 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/video_codec_information.h View 1 chunk +6 lines, -7 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/vp8_partition_aggregator.cc View 8 chunks +16 lines, -18 lines 0 comments Download

Messages

Total messages: 17 (8 generated)
danilchap
5 years ago (2015-12-08 08:43:59 UTC) #2
pbos-webrtc
have you run git cl format on this?
5 years ago (2015-12-08 08:58:08 UTC) #3
danilchap
On 2015/12/08 08:58:08, pbos-webrtc wrote: > have you run git cl format on this? yes, ...
5 years ago (2015-12-08 09:38:41 UTC) #4
mflodman
LGTM
5 years ago (2015-12-10 08:19:58 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1512493002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1512493002/20001
5 years ago (2015-12-10 08:38:43 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: android_clang_dbg on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/android_clang_dbg/builds/9486) android_compile_x64_dbg on tryserver.webrtc (JOB_FAILED, ...
5 years ago (2015-12-10 08:39:34 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1512493002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1512493002/40001
5 years ago (2015-12-10 08:44:54 UTC) #13
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years ago (2015-12-10 10:39:46 UTC) #15
commit-bot: I haz the power
5 years ago (2015-12-10 10:39:52 UTC) #17
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/162abd3562d7b08ab36569800d757b52739b9249
Cr-Commit-Position: refs/heads/master@{#10966}

Powered by Google App Engine
This is Rietveld 408576698