Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issue 1512483003: Add encode/decode time tracing to audio_coding. (Closed)

Created:
5 years ago by pbos-webrtc
Modified:
5 years ago
Reviewers:
hlundin-webrtc
CC:
webrtc-reviews_webrtc.org, kwiberg-webrtc, tlegrand-webrtc, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, peah-webrtc, minyue-webrtc
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Add encode/decode time tracing to audio_coding. Also removes virtual from VideoDecoder::Decode and updated mocks and tests accordingly to use VideoDecoder::DecodeInternal instead. BUG=webrtc:5167 R=henrik.lundin@webrtc.org Committed: https://chromium.googlesource.com/external/webrtc/+/d7b7ae8bdaaf51d885bbbcf6d2ccd2da2522ab03

Patch Set 1 #

Total comments: 2

Patch Set 2 : add comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+99 lines, -79 lines) Patch
M webrtc/modules/audio_coding/acm2/audio_coding_module_unittest_oldapi.cc View 1 2 chunks +24 lines, -2 lines 0 comments Download
M webrtc/modules/audio_coding/codecs/audio_decoder.h View 2 chunks +13 lines, -13 lines 0 comments Download
M webrtc/modules/audio_coding/codecs/audio_decoder.cc View 3 chunks +3 lines, -6 lines 0 comments Download
M webrtc/modules/audio_coding/codecs/audio_encoder.cc View 2 chunks +3 lines, -0 lines 0 comments Download
M webrtc/modules/audio_coding/neteq/mock/mock_audio_decoder.h View 1 chunk +2 lines, -3 lines 0 comments Download
M webrtc/modules/audio_coding/neteq/mock/mock_external_decoder_pcm16b.h View 3 chunks +3 lines, -5 lines 0 comments Download
M webrtc/modules/audio_coding/neteq/neteq_external_decoder_unittest.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M webrtc/modules/audio_coding/neteq/neteq_impl_unittest.cc View 7 chunks +48 lines, -48 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
pbos-webrtc
PTAL woooo
5 years ago (2015-12-08 10:34:04 UTC) #1
hlundin-webrtc
LGTM with one nit, wooooo! https://codereview.webrtc.org/1512483003/diff/1/webrtc/modules/audio_coding/acm2/audio_coding_module_unittest_oldapi.cc File webrtc/modules/audio_coding/acm2/audio_coding_module_unittest_oldapi.cc (right): https://codereview.webrtc.org/1512483003/diff/1/webrtc/modules/audio_coding/acm2/audio_coding_module_unittest_oldapi.cc#newcode979 webrtc/modules/audio_coding/acm2/audio_coding_module_unittest_oldapi.cc:979: class DecodeForwarder { Comment ...
5 years ago (2015-12-08 10:44:52 UTC) #2
pbos-webrtc
add comment
5 years ago (2015-12-08 12:28:24 UTC) #3
pbos-webrtc
https://codereview.webrtc.org/1512483003/diff/1/webrtc/modules/audio_coding/acm2/audio_coding_module_unittest_oldapi.cc File webrtc/modules/audio_coding/acm2/audio_coding_module_unittest_oldapi.cc (right): https://codereview.webrtc.org/1512483003/diff/1/webrtc/modules/audio_coding/acm2/audio_coding_module_unittest_oldapi.cc#newcode979 webrtc/modules/audio_coding/acm2/audio_coding_module_unittest_oldapi.cc:979: class DecodeForwarder { On 2015/12/08 10:44:52, hlundin-webrtc wrote: > ...
5 years ago (2015-12-08 12:28:27 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1512483003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1512483003/20001
5 years ago (2015-12-08 12:28:55 UTC) #7
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/d7b7ae8bdaaf51d885bbbcf6d2ccd2da2522ab03 Cr-Commit-Position: refs/heads/master@{#10935}
5 years ago (2015-12-08 12:41:51 UTC) #9
pbos-webrtc
5 years ago (2015-12-08 12:47:11 UTC) #11
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
d7b7ae8bdaaf51d885bbbcf6d2ccd2da2522ab03 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698