Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(62)

Issue 1511753003: RTCCertificate::Expires() and ::HasExpired() implemented (Closed)

Created:
5 years ago by hbos
Modified:
5 years ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

RTCCertificate::Expires() and ::HasExpired() implemented using SSLCertificate::CertificateExpirationTime(). This is a re-upload of https://codereview.webrtc.org/1494103003 which was reverted and now re-landing. BUG=chromium:544894 Committed: https://crrev.com/3980d4696059b0f92a181c127d9051176cc44872 Cr-Commit-Position: refs/heads/master@{#10951}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+144 lines, -12 lines) Patch
M webrtc/base/base_tests.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/base/fakesslidentity.h View 3 chunks +12 lines, -3 lines 0 comments Download
M webrtc/base/rtccertificate.h View 1 chunk +5 lines, -2 lines 0 comments Download
M webrtc/base/rtccertificate.cc View 2 chunks +8 lines, -6 lines 0 comments Download
A webrtc/base/rtccertificate_unittests.cc View 1 chunk +116 lines, -0 lines 0 comments Download
M webrtc/base/sslidentity.h View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 11 (5 generated)
hbos
Please take a look, i.e. rubberstamp the re-landing of this CL.
5 years ago (2015-12-09 10:43:05 UTC) #3
torbjorng (webrtc)
lgtm
5 years ago (2015-12-09 11:56:11 UTC) #4
hta-webrtc
lgtm
5 years ago (2015-12-09 12:07:35 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1511753003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1511753003/1
5 years ago (2015-12-09 12:10:48 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-09 13:26:54 UTC) #9
commit-bot: I haz the power
5 years ago (2015-12-09 13:27:02 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3980d4696059b0f92a181c127d9051176cc44872
Cr-Commit-Position: refs/heads/master@{#10951}

Powered by Google App Engine
This is Rietveld 408576698