Add APK targets to build libjingle tests for Android.

Add APK targets to build libjingle_peerconnection_unittests for Android.

BUG=webrtc:2365
The work started from the work by kjellander@ in https://codereview.webrtc.org/1413663003/

Committed: https://crrev.com/a78c0211fd50369a75a962385db6163bd8ded239
Cr-Commit-Position: refs/heads/master@{#11007}

[perkj_webrtc, 2015-12-11 11:16:03]

Description was changed from

==========
Add APK targets to build libjingle tests for Android.

BUG=webrtc:2365, chromium:543820

patch from issue 1413663003 at patchset 20001
(http://crrev.com/1413663003#ps20001)
WIP
==========

to

==========
Add APK targets to build libjingle_peerconnection_unittests for Android.

BUG=webrtc:2365

The work started from the work by kjellander@ in
https://codereview.webrtc.org/1413663003/
==========

[perkj_webrtc, 2015-12-13 12:06:39]

perkj@webrtc.org changed reviewers:
+ kjellander@webrtc.org, tommi@webrtc.org

[perkj_webrtc, 2015-12-13 12:06:40]

Please?

[tommi, 2015-12-13 14:02:56]

lgtm

https://codereview.webrtc.org/1511633002/diff/120001/talk/app/webrtc/java/jni...
File talk/app/webrtc/java/jni/jni_onload.cc (right):

https://codereview.webrtc.org/1511633002/diff/120001/talk/app/webrtc/java/jni...
talk/app/webrtc/java/jni/jni_onload.cc:43: RTC_CHECK(rtc::InitializeSSL()) <<
"Failed to InitializeSSL()";
Dcheck that ret is 0 first?

https://codereview.webrtc.org/1511633002/diff/120001/webrtc/test/field_trial.cc
File webrtc/test/field_trial.cc (right):

https://codereview.webrtc.org/1511633002/diff/120001/webrtc/test/field_trial....
webrtc/test/field_trial.cc:58: field_trials.find(name)->second != group_name)
{}

[kjellander_webrtc, 2015-12-14 04:37:50]

https://codereview.webrtc.org/1511633002/diff/120001/talk/app/webrtc/test/and...
File talk/app/webrtc/test/androidtestinitializer.cc (right):

https://codereview.webrtc.org/1511633002/diff/120001/talk/app/webrtc/test/and...
talk/app/webrtc/test/androidtestinitializer.cc:43: #include
"webrtc/voice_engine/include/voe_base.h"
sort alphabetically.

https://codereview.webrtc.org/1511633002/diff/120001/talk/libjingle.gyp
File talk/libjingle.gyp (right):

https://codereview.webrtc.org/1511633002/diff/120001/talk/libjingle.gyp#newco...
talk/libjingle.gyp:81: 'app/webrtc/androidvideocapturer.cc',
Now these will be built when building in Chromium (build_with_chromium==1). Will
that work?

https://codereview.webrtc.org/1511633002/diff/120001/webrtc/build/apk_tests.gyp
File webrtc/build/apk_tests.gyp (right):

https://codereview.webrtc.org/1511633002/diff/120001/webrtc/build/apk_tests.g...
webrtc/build/apk_tests.gyp:75: '../build/apk_test.gypi',
Add a comment here about why we have to use our own .gypi for this (due to the
bug regarding targets starting with "lib" as mentioned in apk_test.gypi). It
seems useful as it's very easy to miss the difference between this target and
the others.

https://codereview.webrtc.org/1511633002/diff/120001/webrtc/test/field_trial.h
File webrtc/test/field_trial.h (right):

https://codereview.webrtc.org/1511633002/diff/120001/webrtc/test/field_trial....
webrtc/test/field_trial.h:42: 
nit: remove blank line.

[perkj_webrtc, 2015-12-14 07:22:21]

ptal

https://codereview.webrtc.org/1511633002/diff/120001/talk/app/webrtc/java/jni...
File talk/app/webrtc/java/jni/jni_onload.cc (right):

https://codereview.webrtc.org/1511633002/diff/120001/talk/app/webrtc/java/jni...
talk/app/webrtc/java/jni/jni_onload.cc:43: RTC_CHECK(rtc::InitializeSSL()) <<
"Failed to InitializeSSL()";
On 2015/12/13 14:02:55, tommi (webrtc) wrote:
> Dcheck that ret is 0 first? 

Done.

https://codereview.webrtc.org/1511633002/diff/120001/talk/app/webrtc/test/and...
File talk/app/webrtc/test/androidtestinitializer.cc (right):

https://codereview.webrtc.org/1511633002/diff/120001/talk/app/webrtc/test/and...
talk/app/webrtc/test/androidtestinitializer.cc:43: #include
"webrtc/voice_engine/include/voe_base.h"
On 2015/12/14 04:37:50, kjellander (webrtc) wrote:
> sort alphabetically.

Done.

https://codereview.webrtc.org/1511633002/diff/120001/talk/libjingle.gyp
File talk/libjingle.gyp (right):

https://codereview.webrtc.org/1511633002/diff/120001/talk/libjingle.gyp#newco...
talk/libjingle.gyp:81: 'app/webrtc/androidvideocapturer.cc',
On 2015/12/14 04:37:50, kjellander (webrtc) wrote:
> Now these will be built when building in Chromium (build_with_chromium==1).
Will
> that work?

I think we should just remove the build_with_chromium==0 below, combine these
and give it a try. I don't' see why but on the other hand, nothing of the java
or jni things should ever be used in chrome.

https://codereview.webrtc.org/1511633002/diff/120001/webrtc/build/apk_tests.gyp
File webrtc/build/apk_tests.gyp (right):

https://codereview.webrtc.org/1511633002/diff/120001/webrtc/build/apk_tests.g...
webrtc/build/apk_tests.gyp:75: '../build/apk_test.gypi',
On 2015/12/14 04:37:50, kjellander (webrtc) wrote:
> Add a comment here about why we have to use our own .gypi for this (due to the
> bug regarding targets starting with "lib" as mentioned in apk_test.gypi). It
> seems useful as it's very easy to miss the difference between this target and
> the others.

Done.

https://codereview.webrtc.org/1511633002/diff/120001/webrtc/test/field_trial.cc
File webrtc/test/field_trial.cc (right):

https://codereview.webrtc.org/1511633002/diff/120001/webrtc/test/field_trial....
webrtc/test/field_trial.cc:58: field_trials.find(name)->second != group_name)
On 2015/12/13 14:02:55, tommi (webrtc) wrote:
> {} 

Done.

https://codereview.webrtc.org/1511633002/diff/120001/webrtc/test/field_trial.h
File webrtc/test/field_trial.h (right):

https://codereview.webrtc.org/1511633002/diff/120001/webrtc/test/field_trial....
webrtc/test/field_trial.h:42: 
On 2015/12/14 04:37:50, kjellander (webrtc) wrote:
> nit: remove blank line.

Done.

[kjellander_webrtc, 2015-12-14 08:50:43]

lgtm

https://codereview.webrtc.org/1511633002/diff/120001/talk/libjingle.gyp
File talk/libjingle.gyp (right):

https://codereview.webrtc.org/1511633002/diff/120001/talk/libjingle.gyp#newco...
talk/libjingle.gyp:81: 'app/webrtc/androidvideocapturer.cc',
On 2015/12/14 07:22:21, perkj1 wrote:
> On 2015/12/14 04:37:50, kjellander (webrtc) wrote:
> > Now these will be built when building in Chromium (build_with_chromium==1).
> Will
> > that work?
> 
> I think we should just remove the build_with_chromium==0 below, combine these
> and give it a try. I don't' see why but on the other hand, nothing of the java
> or jni things should ever be used in chrome.

Fair enough, since Chromium uses it's own GYP file for libjingle.
But isn't that something we want to move away from?
Either way, I guess that will still require a bunch of change sin our own GYP
files, so let's keep that out of this CL.

[perkj_webrtc, 2015-12-14 09:34:10]

The CQ bit was checked by perkj@webrtc.org

[perkj_webrtc, 2015-12-14 09:34:11]

The patchset sent to the CQ was uploaded after l-g-t-m from tommi@webrtc.org
Link to the patchset: https://codereview.webrtc.org/1511633002/#ps180001 (title:
" ")

[commit-bot: I haz the power, 2015-12-14 09:34:20]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1511633002/180001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1511633002/180001

[commit-bot: I haz the power, 2015-12-14 10:41:35]

Description was changed from

==========
Add APK targets to build libjingle_peerconnection_unittests for Android.

BUG=webrtc:2365

The work started from the work by kjellander@ in
https://codereview.webrtc.org/1413663003/
==========

to

==========
Add APK targets to build libjingle_peerconnection_unittests for Android.

BUG=webrtc:2365

The work started from the work by kjellander@ in
https://codereview.webrtc.org/1413663003/
==========

[commit-bot: I haz the power, 2015-12-14 10:41:36]

Committed patchset #10 (id:180001)

[commit-bot: I haz the power, 2015-12-14 10:41:41]

Description was changed from

==========
Add APK targets to build libjingle_peerconnection_unittests for Android.

BUG=webrtc:2365

The work started from the work by kjellander@ in
https://codereview.webrtc.org/1413663003/
==========

to

==========
Add APK targets to build libjingle_peerconnection_unittests for Android.

BUG=webrtc:2365

The work started from the work by kjellander@ in
https://codereview.webrtc.org/1413663003/

Committed: https://crrev.com/a78c0211fd50369a75a962385db6163bd8ded239
Cr-Commit-Position: refs/heads/master@{#11007}
==========

[commit-bot: I haz the power, 2015-12-14 10:41:42]

Patchset 10 (id:??) landed as
https://crrev.com/a78c0211fd50369a75a962385db6163bd8ded239
Cr-Commit-Position: refs/heads/master@{#11007}

[stefan-webrtc, 2015-12-14 12:30:53]

A revert of this CL (patchset #10 id:180001) has been created in
https://codereview.webrtc.org/1521993002/ by stefan@webrtc.org.

The reason for reverting is: Breaks bots..