Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Unified Diff: webrtc/sound/alsasoundsystem.cc

Issue 1511603004: Enable cpplint for more webrtc subfolders and fix all uncovered cpplint errors. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/sound/alsasoundsystem.cc
diff --git a/webrtc/sound/alsasoundsystem.cc b/webrtc/sound/alsasoundsystem.cc
index 3f97446e0610f63806b45bcb846bd8e37e847607..ac0aa772d261be7a44f49ea5b9e0c53fb5d64322 100644
--- a/webrtc/sound/alsasoundsystem.cc
+++ b/webrtc/sound/alsasoundsystem.cc
@@ -11,6 +11,7 @@
#include "webrtc/sound/alsasoundsystem.h"
#include <algorithm>
+#include <string>
#include "webrtc/base/arraysize.h"
#include "webrtc/base/common.h"
@@ -259,12 +260,12 @@ class AlsaInputStream :
}
bool GetVolume(int *volume) override {
- // TODO: Implement this.
+ // TODO(henrike): Implement this.
tommi 2015/12/10 09:29:36 please assign these to henrika instead.
joachim 2015/12/10 09:37:51 Done.
return false;
}
bool SetVolume(int volume) override {
- // TODO: Implement this.
+ // TODO(henrike): Implement this.
return false;
}
@@ -390,12 +391,12 @@ class AlsaOutputStream : public SoundOutputStreamInterface,
}
bool GetVolume(int *volume) override {
- // TODO: Implement this.
+ // TODO(henrike): Implement this.
return false;
}
bool SetVolume(int volume) override {
- // TODO: Implement this.
+ // TODO(henrike): Implement this.
return false;
}
@@ -569,7 +570,6 @@ bool AlsaSoundSystem::EnumerateDevices(
strcmp(name, ignore_null) != 0 &&
strcmp(name, ignore_pulse) != 0 &&
!rtc::starts_with(name, ignore_prefix)) {
-
// Yes, we do.
char *desc = symbol_table_.snd_device_name_get_hint()(*list, "DESC");
if (!desc) {
@@ -622,7 +622,6 @@ StreamInterface *AlsaSoundSystem::OpenDevice(
int wait_timeout_ms,
int flags,
int freq)) {
-
if (!IsInitialized()) {
return NULL;
}

Powered by Google App Engine
This is Rietveld 408576698