Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Side by Side Diff: PRESUBMIT.py

Issue 1511603004: Enable cpplint for more webrtc subfolders and fix all uncovered cpplint errors. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Feedback from tommi Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | webrtc/common_video/i420_video_frame_unittest.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2012 The WebRTC project authors. All Rights Reserved. 1 # Copyright (c) 2012 The WebRTC project authors. All Rights Reserved.
2 # 2 #
3 # Use of this source code is governed by a BSD-style license 3 # Use of this source code is governed by a BSD-style license
4 # that can be found in the LICENSE file in the root of the source 4 # that can be found in the LICENSE file in the root of the source
5 # tree. An additional intellectual property rights grant can be found 5 # tree. An additional intellectual property rights grant can be found
6 # in the file PATENTS. All contributing project authors may 6 # in the file PATENTS. All contributing project authors may
7 # be found in the AUTHORS file in the root of the source tree. 7 # be found in the AUTHORS file in the root of the source tree.
8 8
9 import json 9 import json
10 import os 10 import os
11 import platform 11 import platform
12 import re 12 import re
13 import subprocess 13 import subprocess
14 import sys 14 import sys
15 15
16 16
17 # Directories that will be scanned by cpplint by the presubmit script. 17 # Directories that will be scanned by cpplint by the presubmit script.
18 CPPLINT_DIRS = [ 18 CPPLINT_DIRS = [
19 'webrtc/audio', 19 'webrtc/audio',
20 'webrtc/call', 20 'webrtc/call',
21 'webrtc/common_video',
21 'webrtc/examples', 22 'webrtc/examples',
22 'webrtc/modules/video_processing', 23 'webrtc/modules/video_processing',
24 'webrtc/sound',
25 'webrtc/tools',
23 'webrtc/video', 26 'webrtc/video',
24 ] 27 ]
25 28
26 # List of directories of "supported" native APIs. That means changes to headers 29 # List of directories of "supported" native APIs. That means changes to headers
27 # will be done in a compatible way following this scheme: 30 # will be done in a compatible way following this scheme:
28 # 1. Non-breaking changes are made. 31 # 1. Non-breaking changes are made.
29 # 2. The old APIs as marked as deprecated (with comments). 32 # 2. The old APIs as marked as deprecated (with comments).
30 # 3. Deprecation is announced to discuss-webrtc@googlegroups.com and 33 # 3. Deprecation is announced to discuss-webrtc@googlegroups.com and
31 # webrtc-users@google.com (internal list). 34 # webrtc-users@google.com (internal list).
32 # 4. (later) The deprecated APIs are removed. 35 # 4. (later) The deprecated APIs are removed.
(...skipping 425 matching lines...) Expand 10 before | Expand all | Expand 10 after
458 for builder in masters[master]: 461 for builder in masters[master]:
459 if 'presubmit' in builder: 462 if 'presubmit' in builder:
460 # Do not trigger presubmit builders, since they're likely to fail 463 # Do not trigger presubmit builders, since they're likely to fail
461 # (e.g. OWNERS checks before finished code review), and we're running 464 # (e.g. OWNERS checks before finished code review), and we're running
462 # local presubmit anyway. 465 # local presubmit anyway.
463 pass 466 pass
464 else: 467 else:
465 try_config[master][builder] = ['defaulttests'] 468 try_config[master][builder] = ['defaulttests']
466 469
467 return try_config 470 return try_config
OLDNEW
« no previous file with comments | « no previous file | webrtc/common_video/i420_video_frame_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698