Enable cpplint for more webrtc subfolders and fix all uncovered cpplint errors.

Enable cpplint for more webrtc subfolders and fix all uncovered cpplint errors.

This CL enableds cpplint for webrtc/common_video, webrtc/sound and webrtc/tools.

BUG=webrtc:5273
TESTED=Fixed issues reported by:
find webrtc/common_video webrtc/sound webrtc/tools -type f -name *.cc -o -name *.h | xargs cpplint.py
followed by 'git cl presubmit'.

Committed: https://crrev.com/0f2e939a92fc1a70a67a9fc141d1f1d006bcded9
Cr-Commit-Position: refs/heads/master@{#10967}

[joachim, 2015-12-10 00:01:50]

jbauch@webrtc.org changed reviewers:
+ kjellander@webrtc.org, stefan@webrtc.org, tommi@webrtc.org

[joachim, 2015-12-10 00:01:51]

More low-hanging fruit...

@kjellander: I used the names from git blame for anonymous TODOs as you
suggested. Also ptal webrtc/tools

@stefan: ptal webrtc/common_video

@tommi: ptal webrtc/sound

[kjellander_webrtc, 2015-12-10 07:07:43]

webrtc/tools: lgtm

[stefan-webrtc, 2015-12-10 07:55:48]

webrtc/common_video: lgtm

[tommi, 2015-12-10 09:29:36]

lgtm for webrtc/sound % minor comments below

https://codereview.webrtc.org/1511603004/diff/1/webrtc/sound/alsasoundsystem.cc
File webrtc/sound/alsasoundsystem.cc (right):

https://codereview.webrtc.org/1511603004/diff/1/webrtc/sound/alsasoundsystem....
webrtc/sound/alsasoundsystem.cc:263: // TODO(henrike): Implement this.
please assign these to henrika instead.

https://codereview.webrtc.org/1511603004/diff/1/webrtc/sound/pulseaudiosounds...
File webrtc/sound/pulseaudiosoundsystem.cc (right):

https://codereview.webrtc.org/1511603004/diff/1/webrtc/sound/pulseaudiosounds...
webrtc/sound/pulseaudiosoundsystem.cc:380: PulseAudioInputStream *instance;
nit: can you change this to |Type* foo| style?

https://codereview.webrtc.org/1511603004/diff/1/webrtc/sound/pulseaudiosounds...
webrtc/sound/pulseaudiosoundsystem.cc:730: // TODO(henrike): Versions 0.9.16 and
later of Pulse have a new API for
henrika here to (henrike isn't working on webrtc now)

https://codereview.webrtc.org/1511603004/diff/1/webrtc/sound/pulseaudiosounds...
webrtc/sound/pulseaudiosoundsystem.cc:775: PulseAudioOutputStream *instance;
nit: same here

[joachim, 2015-12-10 09:37:52]

Thanks, all changed.

https://codereview.webrtc.org/1511603004/diff/1/webrtc/sound/alsasoundsystem.cc
File webrtc/sound/alsasoundsystem.cc (right):

https://codereview.webrtc.org/1511603004/diff/1/webrtc/sound/alsasoundsystem....
webrtc/sound/alsasoundsystem.cc:263: // TODO(henrike): Implement this.
On 2015/12/10 09:29:36, tommi (webrtc) wrote:
> please assign these to henrika instead.

Done.

https://codereview.webrtc.org/1511603004/diff/1/webrtc/sound/pulseaudiosounds...
File webrtc/sound/pulseaudiosoundsystem.cc (right):

https://codereview.webrtc.org/1511603004/diff/1/webrtc/sound/pulseaudiosounds...
webrtc/sound/pulseaudiosoundsystem.cc:380: PulseAudioInputStream *instance;
On 2015/12/10 09:29:36, tommi (webrtc) wrote:
> nit: can you change this to |Type* foo| style?

Done.

https://codereview.webrtc.org/1511603004/diff/1/webrtc/sound/pulseaudiosounds...
webrtc/sound/pulseaudiosoundsystem.cc:730: // TODO(henrike): Versions 0.9.16 and
later of Pulse have a new API for
On 2015/12/10 09:29:36, tommi (webrtc) wrote:
> henrika here to (henrike isn't working on webrtc now)

Done.

https://codereview.webrtc.org/1511603004/diff/1/webrtc/sound/pulseaudiosounds...
webrtc/sound/pulseaudiosoundsystem.cc:775: PulseAudioOutputStream *instance;
On 2015/12/10 09:29:36, tommi (webrtc) wrote:
> nit: same here

Done.

[tommi, 2015-12-10 09:38:59]

The CQ bit was checked by tommi@webrtc.org

[tommi, 2015-12-10 09:38:59]

The patchset sent to the CQ was uploaded after l-g-t-m from tommi@webrtc.org,
kjellander@webrtc.org, stefan@webrtc.org
Link to the patchset: https://codereview.webrtc.org/1511603004/#ps20001 (title:
"Feedback from tommi")

[commit-bot: I haz the power, 2015-12-10 09:39:06]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1511603004/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1511603004/20001

[commit-bot: I haz the power, 2015-12-10 11:11:45]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-12-10 11:11:57]

Description was changed from

==========
Enable cpplint for more webrtc subfolders and fix all uncovered cpplint errors.

This CL enableds cpplint for webrtc/common_video, webrtc/sound and webrtc/tools.

BUG=webrtc:5273

TESTED=Fixed issues reported by:
find webrtc/common_video webrtc/sound webrtc/tools -type f -name *.cc -o -name
*.h | xargs cpplint.py
followed by 'git cl presubmit'.
==========

to

==========
Enable cpplint for more webrtc subfolders and fix all uncovered cpplint errors.

This CL enableds cpplint for webrtc/common_video, webrtc/sound and webrtc/tools.

BUG=webrtc:5273

TESTED=Fixed issues reported by:
find webrtc/common_video webrtc/sound webrtc/tools -type f -name *.cc -o -name
*.h | xargs cpplint.py
followed by 'git cl presubmit'.

Committed: https://crrev.com/0f2e939a92fc1a70a67a9fc141d1f1d006bcded9
Cr-Commit-Position: refs/heads/master@{#10967}
==========

[commit-bot: I haz the power, 2015-12-10 11:11:58]

Patchset 2 (id:??) landed as
https://crrev.com/0f2e939a92fc1a70a67a9fc141d1f1d006bcded9
Cr-Commit-Position: refs/heads/master@{#10967}