Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1511413007:
Remove ancient VoE suppressions. (Closed)
|
Created:
5 years ago by the sun Modified:
5 years ago Reviewers:
kjellander_webrtc CC:
webrtc-reviews_webrtc.org, tlegrand-webrtc Base URL:
https://chromium.googlesource.com/external/webrtc.git@master Target Ref:
refs/pending/heads/master Project:
webrtc Visibility:
Public. |
DescriptionRemove ancient VoE suppressions.
BUG=webrtc:332
Committed: https://crrev.com/b562c33f157f0af7e63eac66e6e008e8178ab8c0
Cr-Commit-Position: refs/heads/master@{#10988}
Patch Set 1 #
Messages
Total messages: 18 (8 generated)
Description was changed from ========== Fix ancient suppressions in VoE. BUG=332 patch from issue 1505123004 at patchset 40001 (http://crrev.com/1505123004#ps40001) ========== to ========== Fix ancient suppressions in VoE. BUG=webrtc:332 patch from issue 1505123004 at patchset 40001 (http://crrev.com/1505123004#ps40001) ==========
solenberg@webrtc.org changed reviewers: + phoglund@webrtc.org
It appears these memcheck failures don't appear anymore. I'm removing them and closing the bug.
solenberg@webrtc.org changed reviewers: + kjellander@webrtc.org - phoglund@webrtc.org
Description was changed from ========== Fix ancient suppressions in VoE. BUG=webrtc:332 patch from issue 1505123004 at patchset 40001 (http://crrev.com/1505123004#ps40001) ========== to ========== Remove ancient VoE suppressions. BUG=webrtc:332 patch from issue 1505123004 at patchset 40001 (http://crrev.com/1505123004#ps40001) ==========
Description was changed from ========== Remove ancient VoE suppressions. BUG=webrtc:332 patch from issue 1505123004 at patchset 40001 (http://crrev.com/1505123004#ps40001) ========== to ========== Remove ancient VoE suppressions. BUG=webrtc:332 ==========
On 2015/12/10 23:17:06, the sun wrote: > It appears these memcheck failures don't appear anymore. I'm removing them and > closing the bug. Don't you think it is because they're suppressed? I triggered the linux_memcheck trybot for us to find out. You have my lgtm if that goes green (or only fails on something unrelated). No need to run any of the other trybots for a patch like this, please :)
On 2015/12/11 09:23:57, kjellander (webrtc) wrote: > On 2015/12/10 23:17:06, the sun wrote: > > It appears these memcheck failures don't appear anymore. I'm removing them and > > closing the bug. > > Don't you think it is because they're suppressed? I triggered the linux_memcheck > trybot for us to find out. > You have my lgtm if that goes green (or only fails on something unrelated). > > No need to run any of the other trybots for a patch like this, please :) I have run the linux_memcheck a few times without the suppressions and it looks ok. May still be flakes that trigger occasionally though.
On 2015/12/11 09:26:00, the sun wrote: > On 2015/12/11 09:23:57, kjellander (webrtc) wrote: > > On 2015/12/10 23:17:06, the sun wrote: > > > It appears these memcheck failures don't appear anymore. I'm removing them > and > > > closing the bug. > > > > Don't you think it is because they're suppressed? I triggered the > linux_memcheck > > trybot for us to find out. > > You have my lgtm if that goes green (or only fails on something unrelated). > > > > No need to run any of the other trybots for a patch like this, please :) > > I have run the linux_memcheck a few times without the suppressions and it looks > ok. May still be flakes that trigger occasionally though. Oh, I didn't know (it hasn't reported anything to this CL at least). By the way, why does the mail notifications for this CL point to https://codereview.chromium.org/1511413007/ ? Do you have some weird setup or did you just accidentally visit the wrong URL?
On 2015/12/11 09:37:00, kjellander (webrtc) wrote: > On 2015/12/11 09:26:00, the sun wrote: > > On 2015/12/11 09:23:57, kjellander (webrtc) wrote: > > > On 2015/12/10 23:17:06, the sun wrote: > > > > It appears these memcheck failures don't appear anymore. I'm removing them > > and > > > > closing the bug. > > > > > > Don't you think it is because they're suppressed? I triggered the > > linux_memcheck > > > trybot for us to find out. > > > You have my lgtm if that goes green (or only fails on something unrelated). > > > > > > No need to run any of the other trybots for a patch like this, please :) > > > > I have run the linux_memcheck a few times without the suppressions and it > looks > > ok. May still be flakes that trigger occasionally though. > > Oh, I didn't know (it hasn't reported anything to this CL at least). > By the way, why does the mail notifications for this CL point to > https://codereview.chromium.org/1511413007/ ? Do you have some weird setup or > did you just accidentally visit the wrong URL? Accidentally I uploaded the CL using my @google.com persona, that's where I ran a few tries on the memcheck bot: https://codereview.chromium.org/1505123004/. Sorry about the confusion.
On 2015/12/11 09:45:58, the sun wrote: > On 2015/12/11 09:37:00, kjellander (webrtc) wrote: > > On 2015/12/11 09:26:00, the sun wrote: > > > On 2015/12/11 09:23:57, kjellander (webrtc) wrote: > > > > On 2015/12/10 23:17:06, the sun wrote: > > > > > It appears these memcheck failures don't appear anymore. I'm removing > them > > > and > > > > > closing the bug. > > > > > > > > Don't you think it is because they're suppressed? I triggered the > > > linux_memcheck > > > > trybot for us to find out. > > > > You have my lgtm if that goes green (or only fails on something > unrelated). > > > > > > > > No need to run any of the other trybots for a patch like this, please :) > > > > > > I have run the linux_memcheck a few times without the suppressions and it > > looks > > > ok. May still be flakes that trigger occasionally though. > > > > Oh, I didn't know (it hasn't reported anything to this CL at least). > > By the way, why does the mail notifications for this CL point to > > https://codereview.chromium.org/1511413007/ ? Do you have some weird setup or > > did you just accidentally visit the wrong URL? > > Accidentally I uploaded the CL using my @google.com persona, that's where I ran > a few tries on the memcheck bot: https://codereview.chromium.org/1505123004/. > Sorry about the confusion. Ah, then you can just go ahead and land this manually (or with NOTRY=True).
The CQ bit was checked by solenberg@webrtc.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1511413007/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1511413007/1
Message was sent while issue was closed.
Description was changed from ========== Remove ancient VoE suppressions. BUG=webrtc:332 ========== to ========== Remove ancient VoE suppressions. BUG=webrtc:332 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Remove ancient VoE suppressions. BUG=webrtc:332 ========== to ========== Remove ancient VoE suppressions. BUG=webrtc:332 Committed: https://crrev.com/b562c33f157f0af7e63eac66e6e008e8178ab8c0 Cr-Commit-Position: refs/heads/master@{#10988} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/b562c33f157f0af7e63eac66e6e008e8178ab8c0 Cr-Commit-Position: refs/heads/master@{#10988} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
