Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(112)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1511413005: [rtp_rtcp] Lint errors cleared from rtp_rtcp/test (Closed)

Created:
5 years ago by danilchap
Modified:
5 years ago
Reviewers:
mflodman
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, zhuangzesen_agora.io, stefan-webrtc, mflodman
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

[rtp_rtcp] Lint errors cleared from rtp_rtcp/test except rand() function that is subject of CL#1519503002 and namespace that is fixed in CL#1506823002 BUG=webrtc:5277 R=mflodman Committed: https://crrev.com/40f349fddafd97c3f4cd0e37407bd1968496cb09 Cr-Commit-Position: refs/heads/master@{#11012}

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : BWEStandAlone subfolder excluded because should be deleted #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -52 lines) Patch
M webrtc/modules/rtp_rtcp/test/testAPI/test_api_audio.cc View 1 3 chunks +3 lines, -3 lines 0 comments Download
M webrtc/modules/rtp_rtcp/test/testAPI/test_api_rtcp.cc View 1 1 chunk +8 lines, -9 lines 0 comments Download
M webrtc/modules/rtp_rtcp/test/testFec/test_fec.cc View 1 13 chunks +27 lines, -30 lines 0 comments Download
M webrtc/modules/rtp_rtcp/test/testFec/test_packet_masks_metrics.cc View 1 8 chunks +10 lines, -10 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
danilchap
5 years ago (2015-12-11 09:22:47 UTC) #1
mflodman
LGTM
5 years ago (2015-12-14 12:23:37 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1511413005/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1511413005/40001
5 years ago (2015-12-14 12:57:34 UTC) #4
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years ago (2015-12-14 14:39:37 UTC) #5
commit-bot: I haz the power
5 years ago (2015-12-14 14:39:43 UTC) #7
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/40f349fddafd97c3f4cd0e37407bd1968496cb09
Cr-Commit-Position: refs/heads/master@{#11012}

Powered by Google App Engine
This is Rietveld 408576698